Skip to content

Commit

Permalink
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Browse files Browse the repository at this point in the history
# Conflicts:
#	.pre-commit-config.yaml
  • Loading branch information
mcdonnnj committed Nov 20, 2024
2 parents d8b5718 + a794735 commit 465040e
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ repos:

# Ansible hooks
- repo: https://github.com/ansible/ansible-lint
rev: v24.9.2
rev: v24.10.0
hooks:
- id: ansible-lint
additional_dependencies:
Expand All @@ -191,17 +191,36 @@ repos:
# hook identifies a vulnerability in ansible-core 2.16.13,
# but all versions of ansible 9 have a dependency on
# ~=2.16.X.
<<<<<<< HEAD
=======
#
# It is also a good idea to go ahead and upgrade to version
# 10 since version 9 is going EOL at the end of November:
# https://endoflife.date/ansible
>>>>>>> a7947357cfeee58bc121243a2c76c5bbdc064e35
# - ansible>=10,<11
# ansible-core 2.16.3 through 2.16.6 suffer from the bug
# discussed in ansible/ansible#82702, which breaks any
# symlinked files in vars, tasks, etc. for any Ansible role
# installed via ansible-galaxy. Hence we never want to
# install those versions.
#
<<<<<<< HEAD
# Note that the pip-audit pre-commit hook identifies a vulnerability
# in ansible-core 2.16.13. Normally we would pin ansible-core
# accordingly (>2.16.13), but the above pin of ansible>=10 effectively
# pins ansible-core to >=2.17 so that's what we do here.
=======
# Note that the pip-audit pre-commit hook identifies a
# vulnerability in ansible-core 2.16.13. The pin of
# ansible-core to >=2.17 effectively also pins ansible to
# >=10.
#
# It is also a good idea to go ahead and upgrade to
# ansible-core 2.17 since security support for ansible-core
# 2.16 ends this month:
# https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix
>>>>>>> a7947357cfeee58bc121243a2c76c5bbdc064e35
#
# Note that any changes made to this dependency must also be
# made in requirements.txt in cisagov/skeleton-packer and
Expand Down

0 comments on commit 465040e

Please sign in to comment.