Alphabetize the Ansible provisioner modules in the Terraform configurations #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the module keys and all key values are sorted alphabetically. The `source` key is left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` and `depends_on` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` key is left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` key is left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source`, `count`, and `depends_on` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source`, `count`, and `depends_on` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source`, `count`, and `depends_on` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` and `depends_on` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` and `count` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` and `count` keys are left separately at the top for better visibility.
Ensure the module keys and all key values are sorted alphabetically. The `source` and `count` keys are left separately at the top for better visibility. Although this configuration is not in current use it is updated to maintain consistent practices in this project.
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Oct 19, 2023
mcdonnnj
deleted the
improvement/alphabetize_ansible_provisioner_members
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request alphabetizes the arguments in all of the Ansible provisioners in this repository. This includes the keys and the elements of any values that are lists (where order does not matter).
💭 Motivation and context
This is consistent with our general development practices and finishes work that has been done toward this in a piecemeal fashion. It also serves to resolve the request in #699 (comment).
🧪 Testing
Automated testing passes.
✅ Pre-approval checklist