Adjust the text replacement logic #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is more performant to prune the entire .git/ directory than to check each object and see if it begins with './.git' as is currently being done.
Source repository names may show up in attribution comments for ignore directives in this file. We do not want to replace these and there is nothing else that would need to be replaced in this file.
Add an additional `-exec` to the name replacement logic to include the replacement of the organization name. This will replace any instances of <src_org>/<src_repo> with <dest_org>/<dest_repo< before the replacement of repository names occurs. This will help ensure that all appropriate name replacements are taking place.
mcdonnnj
added
breaking change
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Sep 27, 2023
jasonodoom
approved these changes
Sep 27, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adjusts the functionality of the repository name replacement logic in the following ways:
.git/directory is ignored..github/dependabot.ymlfile.<src_org>/<src_repo>and not just<src_repo>.💭 Motivation and context
I originally looked at this to handle the second bullet point of the above list because there are attribution comments in the Dependabot configuration file. These should not be replaced in repositories based on a skeleton project and there is nothing else that would warrant replacement in that file so it is safe to ignore it completely. While looking at the logic I noticed that the
findseemed to inefficiently ignore the.git/directory and I have run into a problem when using this tool to start projects in my personal account where I have instances ofcisagov/<new_repo_name>such as in the README badges.🧪 Testing
Automated tests pass. I tested the find logic in my WSL container and on my work MacBook to check the logic under both Linux and macOS systems.
✅ Pre-approval checklist
to reflect the changes in this PR.