Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCADEV-185 Li-PCA Setup Refactor/Enhancements #58

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nickviola
Copy link
Contributor

🗣 Description

LiPCA Setup Refactor and Enhancements

💭 Motivation and context

Per Jira issue: PCADEV-185, we need to refactor the V1 lipca_setup bash script to use a python replacement. This issue tracks the conversion of the initial Li-PCA setup script (in pca-gophish-composition repo) to python logic that lives in this repo with the other gophish logic. There will also be updates to the flow of the setup process which are tracked in the linked issue above.

🧪 Testing

Deployment/Testing will be done in COOL staging env2 with multiple team members for feedback. There is a linked subtask to track testing/feedback above.

📷 Screenshots (if appropriate)

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@nickviola nickviola self-assigned this Nov 22, 2021
@nickviola nickviola changed the title add initial lipca setup tests PCADEV-185 Li-PCA Setup Refactor/Enhancements Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant