Skip to content

Commit

Permalink
Merge pull request #2955 from cisagov/es/2140-pr-template-fix
Browse files Browse the repository at this point in the history
2140: Readd keyboard navigability check to design PR review
  • Loading branch information
erinysong authored Oct 17, 2024
2 parents 232ef4b + 0f39d53 commit 61a96c0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Resolves #00
- [ ] Verify migrations are valid and do not conflict with existing migrations

#### Validated user-facing changes as a developer
**Note:** Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
**Note:** Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

- [ ] New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
- [ ] Checked keyboard navigability
Expand All @@ -81,13 +81,12 @@ Resolves #00

- [ ] Checked that the design translated visually
- [ ] Checked behavior. Comment any found issues or broken flows.
- [ ] Checked keyboard navigability
- [ ] Checked different states (empty, one, some, error)
- [ ] Checked for landmarks, page heading structure, and links

#### Validated user-facing changes as a designer

- [ ] Checked different states (empty, one, some, error)
- [ ] Checked keyboard navigability
- [ ] Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
- [ ] Tested with multiple browsers (check off which ones were used)
- [ ] Chrome
Expand Down

0 comments on commit 61a96c0

Please sign in to comment.