-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2934: Django Admin - Dynamic Domain Request edit page [DK] #3040
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
81d3ec0
reordering of fields, js for conditional Approved Domain display
dave-kennedy-ecs b01bb92
javascript hide and show based on portfolio selection
dave-kennedy-ecs fa7bc95
wip
dave-kennedy-ecs 75ef643
wip
dave-kennedy-ecs cc116c5
wip
dave-kennedy-ecs 05a387d
wip
dave-kennedy-ecs 3c9e93e
wip
dave-kennedy-ecs bd22700
updatePortfolioFieldsDataDynamicDisplay
rachidatecs df6649a
revise updatePortfolioFieldsDataDynamicDisplay to work with dynamic d…
rachidatecs e948dc4
wip
dave-kennedy-ecs 661f9ff
revise IDs in contact_detail_list to classes
rachidatecs e013dcc
temp
dave-kennedy-ecs 4c7aaea
Merge branch 'tempdk' into dk/2934-dja-domain-request
dave-kennedy-ecs 5f65f61
wip
dave-kennedy-ecs 4887a47
Dynamic portfolkio senior official handling
rachidatecs 4e12b12
updatePortfolioFieldsDataDynamicDisplay cleanup
rachidatecs b540178
blank value displays on portfolio and suborg, return ids in json
rachidatecs ca523a3
added comments and refactored code for simplicity and readability
dave-kennedy-ecs 96c478e
modify text to links for portfolio fields
dave-kennedy-ecs 2d5da90
git ignore VS code specific files
dave-kennedy-ecs e23a2ee
updated tests, linted some
dave-kennedy-ecs bc86c44
linter
dave-kennedy-ecs 0b28435
api tests written
dave-kennedy-ecs 4a07c9a
comment fix
dave-kennedy-ecs f6062da
lint
dave-kennedy-ecs 15b5252
senior official text found
dave-kennedy-ecs 654df17
fixing a bug in suborganization handling
dave-kennedy-ecs af10118
fixing a bug in suborganization handling
dave-kennedy-ecs 0a11dff
Merge branch 'main' into dk/2934-dja-domain-request
dave-kennedy-ecs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the shortcut as mentioned earlier. The separator and queryset is a minor hack: a current limitation of get_field_links is that it expects a list of items (as it was designed for that), hence the separator / queryset dependency. However with a list size of either one or zero, it will look as you'd expect. What is needed is basically the same exact function but it doesn't operate on a queryset list.
No need to use this, but it may be helpful to know in any event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Zander. I think I will keep this as is in this case. I think it makes most sense for this logic to be in the template, if it is simple enough to define there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough!