#2903: Target Stable/Staging for Clone Workflow #3061
Conversation
|
🥳 Successfully deployed to developer sandbox ms. |
Matt-Spence
changed the title
Matt-Spence
changed the title
| @@ -1,4 +1,4 @@ | |||
| name: Clone Staging Database | |||
| name: Clone Stable Database | |||
|
|
|||
| on: | |||
| schedule: | |||
There was a problem hiding this comment.
The comment here is incorrect, please update
| CF_USERNAME: ${{ secrets.CF_MS_USERNAME }} | ||
| CF_PASSWORD: ${{ secrets.CF_MS_PASSWORD }} | ||
| CF_USERNAME: ${{ secrets.CF_STAGING_USERNAME }} | ||
| CF_PASSWORD: ${{ secrets.CF_STAGING_PASSWORD }} | ||
| steps: | ||
| - name: Clone Database |
There was a problem hiding this comment.
Why are we updating to cf8-cli here?
There was a problem hiding this comment.
also don't you need to do continue-on-error: true so that if this fails before unsharing the service the last step is triggered? reference
There was a problem hiding this comment.
I've been using cf8-cli for months (including when researching for this ticket) with no issues so I figured it would be fine to just go ahead and use it here too.
For your second question: I have set the next step to run always(), which does the same thing as continue-on-error in practice. Just two different ways of accomplishing the same thing.
| @@ -1,4 +1,4 @@ | |||
| name: Clone Staging Database | |||
| name: Clone Stable Database | |||
There was a problem hiding this comment.
| name: Clone Stable Database | |
| # This workflow runs at the top of every hour and can be manually run as needed | |
| # The workflow will copy the database from stable (production) to our staging sandbox. | |
| name: Clone Stable Database |
There was a problem hiding this comment.
Also if the database is missing columns/tables in staging that exist in stable then we do expect this workflow to fail temporarily, correct? If so update this comment to reflect that as that is a very real possibility
There was a problem hiding this comment.
Yes we do, we will need to ensure that the target database has a compatible schema with the source database.
Co-authored-by: Alysia Broddrick <[email protected]>
|
🥳 Successfully deployed to developer sandbox ms. |
There was a problem hiding this comment.
Quick change request can you have the fixtures be it's own step? Reasoning being that it will be faster for us to see what is breaking if it's just the fixtures step that's failing. Having it being in the clone step could make it look like the Cloning is failing
|
🥳 Successfully deployed to developer sandbox ms. |
Ticket
Related to (but does not resolve) #2903
Changes
Context for reviewers
Setup
Code Review Verification Steps
Unfortunately this can't be tested until merging, but we have run existing versions of this workflow against Staging/MS to verify it. Check the GH Actions tab and scroll through the latest runs of the "Clone Staging" workflow to see the results. You can also check Staging/MS to make sure they are functioning properly.
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots