-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #17
base: develop
Are you sure you want to change the base?
Update README #17
Conversation
|
||
```bash | ||
git clone https://github.com/cisagov/mesa-gui | ||
cd /opt/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always going to be writeable? Or do we need to include permission changes here? Not sure that /opt is writeable by users by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, I do call out that the install script in the toolkit is recommended but since the instructions walk through manual setup maybe permission instructions are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added sudo
prior to each command since elevated permissions should be required for these actions.
Source the MESA virtual environment. This activates the environment, isolating the dependencies needed for the MESA-GUI to run: | ||
|
||
```bash | ||
source /opt/MESA-venv/bin/activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is created by the mesa-toolkit installer right? Might be worth mentioning as a bash comment, but if this is walking through the installation as if mesa-toolkit was not used, should we also include creating the venv?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reviewing the instructions this is dependent on running the install script on the mesa-toolkit repo first. So if I'm understanding this comment, your suggesting that I should include instructions on how to do so?
|
||
![image](https://github.com/user-attachments/assets/1091208a-12a2-463e-81aa-960d47dc9497) | ||
|
||
| Job Title | Description | Required | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth mentioning (just above this) what required means in this context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a note to this section.
README.md
Outdated
MESA jobs can be ran individually or automatically in sequential order. To run the scans individually simply select the ![image](https://github.com/user-attachments/assets/208c9b72-7468-4421-a2f0-f9c7434b352f) button for the job you would like to run. | ||
|
||
>[!IMPORTANT] | ||
>It is recommended to run the `Host Discovery Scans` job prior to running any other scans. This will ensure that a `live hosts` file is generated, expediting the time spent performing scans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommended or required? Kind of tying this in with the comment above about what required means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added another note to explain why the scan is required and modified recommended
to required
.
🗣 Description
Update the MESA-GUI README to include more clear instructions on how to use the tool.
💭 Motivation and context
Additional context can be found in issue #16
🧪 Testing
✅ Pre-approval checklist
to reflect the changes in this PR.