Add module variable to allow write permission #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the default the value if true, indicating that the role should be read-only. This agrees with the way the role functioned previously, so the change should cause no surprises. If the value is set to false then the role created will allow for writing in addition to reading.
This is because the role and policy may allow for writing based on the value of var.read_only.
jsf9k
added
documentation
Also update variable descriptions to use "access" instead of "read" since writing may be allowed based on the value of read_only.
jsf9k
force-pushed
the
feature/add-option-for-write-permission
branch
from
29a4d82
to
0e7acae
Compare
dv4harr10
approved these changes
Sep 24, 2024
The phrase that is used depends on the value of the read_only variable. Co-authored-by: Dave Redmin <[email protected]>
jsf9k
force-pushed
the
feature/add-option-for-write-permission
branch
from
137746d
to
3722ace
Compare
This was referenced Sep 27, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds a module variable (
var.read_only) that allows for the addition of write permissions to the IAM role being created.💭 Motivation and context
This change is required in order to create a read-write role that allows access to a particular COOL environment's remote state.
Note also that these changes have been made in a way that is backward compatible with the role's previous behavior, so this is a non-breaking change.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist