Bump up the lower bound on ansible-core
#209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being done because the pip-audit pre-commit hook identifies a vulnerability in ansible-core version 2.16.13. Note that this requires that we bump up ansible to version 10 since all versions of ansible 9 have a dependency on ~=2.16.X.
jsf9k
added
improvement
This was referenced Nov 8, 2024
dv4harr10
approved these changes
Nov 8, 2024
lwersiy
approved these changes
Nov 8, 2024
dav3r
approved these changes
Nov 12, 2024
mcdonnnj
reviewed
Nov 13, 2024
The pin of ansible-core was originally put in place because the pip-audit pre-commit hook identifies a vulnerability in ansible-core 2.16.13. Normally we would pin ansible-core accordingly (>2.16.13), but the earlier pin of ansible>=10 effectively pins ansible-core to >=2.17 so that's what we do here. Co-authored-by: Nick M <[email protected]>
jsf9k
force-pushed
the
improvement/bump-up-lower-bound-pin-for-ansible-core
branch
from
41e3dd4 to
b5a06b4
Compare
2 tasks
5 tasks
This adds even more evidence for why it is a good idea to go ahead and upgrade ansible and ansible-core, in addition to the vulnerability that pip-audit turned up. Co-authored-by: Nick M <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
jsf9k
deleted the
improvement/bump-up-lower-bound-pin-for-ansible-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request bumps up the lower bound on the
ansible-corePython package.See also cisagov/skeleton-generic#196 and the commits cisagov/skeleton-packer@26a8baf and cisagov/skeleton-packer@19fbaf3 in cisagov/skeleton-packer#376.
Supplants #208.
💭 Motivation and context
This is being done because the
pip-auditpre-commithook identifies a vulnerability inansible-coreversion 2.16.13. Note that this requires that we bump up the version ofansibleto version 10 since all versions ofansible9 have a dependency onansible-core~=2.16.X.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist