Fix the needs configurations for the test and build jobs in the build workflow
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures consistent and expected behavior without relying on a chained dependency in the `needs` declarations.
mcdonnnj
added
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
|
I am toggling this to merge when ready because I would like to just push this out with the existing wave for this lineage that has barely been started. |
jsf9k
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request fixes the
needsconfiguration for thetestandbuildjobs in thebuildworkflow. This is mainly about adding a requirement for the newdiagnosticsjob that was added.💭 Motivation and context
This should have been done in #19 but was missed.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist