Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #34

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from

Commits on Feb 14, 2024

  1. Add checks for semantic python versions

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    33582a1 View commit details
    Browse the repository at this point in the history
  2. Refactor code for the semantic check

    This commit will make a few changes. The
    orginal version of the semantic checking
    function was a bit more difficult to read.
    It is now somewhat easier to follow how
    the regex is structured. Also the function
    has been renamed to check_python_version
    since it has 2 functions, making sure that
    the version is semantically correct and the
    second is to make sure that it is installed
    on the user's machine. This makes it easier
    to follow the logic for the flags, -p or
    --python-version and -l or --list-versions
    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9438194 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Add checks for semantic python versions

    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cea8edc View commit details
    Browse the repository at this point in the history
  2. Refactor code for the semantic check

    This commit will make a few changes. The
    orginal version of the semantic checking
    function was a bit more difficult to read.
    It is now somewhat easier to follow how
    the regex is structured. Also the function
    has been renamed to check_python_version
    since it has 2 functions, making sure that
    the version is semantically correct and the
    second is to make sure that it is installed
    on the user's machine. This makes it easier
    to follow the logic for the flags, -p or
    --python-version and -l or --list-versions
    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d5c7c4a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'improvement/correct-semantic-python-version-checks' of h…

    …ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f7b9d05 View commit details
    Browse the repository at this point in the history
  4. Remove example of correct semantic version

    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    327ab73 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Refactor the error message for the user

    Michael Saki committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4dedf50 View commit details
    Browse the repository at this point in the history
  2. Improve the semantic error message

    Michael Saki committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e84deea View commit details
    Browse the repository at this point in the history
  3. Fix grammar

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5fdc7be View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Refactor regex, add link, and improve comments

    Michael Saki committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    42ef8c2 View commit details
    Browse the repository at this point in the history
  2. Update link to use semver.org over regex101.com

    Michael Saki committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a77e5e1 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary period

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5fe14c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Add a meta hook to the pre-commit configuration

    Add the `check-useless-excludes` meta hook to verify that any defined
    `exclude` directives apply to at least one file in the repository.
    mcdonnnj committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b7896a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    260566f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Pin ansible-core when running the ansible-lint linter

    New versions of ansible-core (2.16.7 and 2.17.0) have been released
    that do not suffer from the bug discussed in ansible/ansible#82702.
    This bug broke any symlinked files in vars, tasks, etc. for any
    Ansible role installed via ansible-galaxy.
    
    All versions later than ansible-core 2.16.7 and 2.17.0 should function
    as expected.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj committed May 21, 2024
    Configuration menu
    Copy the full SHA
    07e2b60 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary line

    The line is not only unnecessary, it was commented out to boot!
    jsf9k committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c74e5db View commit details
    Browse the repository at this point in the history
  3. Explain why ansible may need to be added as a dependency for ansible-…

    …lint
    
    On its own ansible-lint does not pull in ansible, only ansible-core.
    Therefore, if an Ansible module lives in ansible instead of
    ansible-core, the linter will complain that the module is unknown.  In
    these cases it is necessary to add the ansible package itself as an
    additional dependency, with the same pinning as is done in
    requirements-test.txt of cisagov/skeleton-ansible-role.
    jsf9k committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2e53e0d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f51fe62 View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    Use the latest v3 release available from NPM.
    mcdonnnj committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8e55b8e View commit details
    Browse the repository at this point in the history
  3. Correct commented-out ansible pin

    The pin now agrees with what is in cisagov/skeleton-ansible-role.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c617bb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de92c3c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #182 from cisagov/improvement/pin-packages-for-ans…

    …ible-lint
    
    Pin packages for `ansible-lint`
    mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7ddea47 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    a68994d View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Use the hashicorp/setup-packer GitHub Action

    Instead of manually installing Packer we can instead leverage the
    hashicorp/setup-packer Action just as we do for Terraform.
    mcdonnnj committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    43b91c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Remove @jasonodoom as a codeowner

    He is no longer a member of @cisagov/vm-dev.
    jsf9k committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8ada75d View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Pin to a specific version

    Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general.
    
    The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2930208 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Bump actions/cache from 3 to 4

    Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    46e0553 View commit details
    Browse the repository at this point in the history
  2. Bump crazy-max/ghaction-github-status from 3 to 4

    Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4.
    - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases)
    - [Commits](crazy-max/ghaction-github-status@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: crazy-max/ghaction-github-status
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3167421 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier hook was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6a58c2c View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    Use the latest v3 release available from NPM.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    553efcb View commit details
    Browse the repository at this point in the history
  3. Merge pull request #170 from cisagov/dependabot/github_actions/crazy-…

    …max/ghaction-github-status-4
    
    Bump crazy-max/ghaction-github-status from 3 to 4
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    184e749 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #171 from cisagov/dependabot/github_actions/action…

    …s/cache-4
    
    Bump actions/cache from 3 to 4
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d99c117 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #187 from cisagov/improvement/use_setup_packer_action

    Use an Action to install Packer in our GitHub Actions workflows
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2491ca0 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #176 from cisagov/improvement/correct-semantic-pyt…

    …hon-version-checks
    
    Add checks for correct semantic version of Python
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f6c9537 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    10e5f6f View commit details
    Browse the repository at this point in the history
  8. Add a pre-commit hook to run pip-audit

    The pip-audit tool will audit any supplied pip requirements files for
    vulnerable packages.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    045a998 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #178 from cisagov/improvement/add_pre-commit_meta_…

    …hook
    
    Add the `check-useless-excludes` hook to the pre-commit configuration
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28dc4ce View commit details
    Browse the repository at this point in the history
  10. Merge pull request #179 from cisagov/improvement/add_pip-audit_pre-co…

    …mmit_hook
    
    Add a pre-commit hook to run `pip-audit`
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5801cec View commit details
    Browse the repository at this point in the history
  11. Merge pull request #184 from cisagov/improvement/pin-flake8-docstrings

    Add a lower-bound pin for the `flake8-docstrings` `pip` package
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e61255c View commit details
    Browse the repository at this point in the history
  12. Merge pull request #185 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hooks
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    44cd1be View commit details
    Browse the repository at this point in the history
  13. Use the rbubley/mirrors-prettier hook for prettier

    This replaces the now archived pre-commit/mirrors-prettier hook.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c502f1a View commit details
    Browse the repository at this point in the history
  14. Merge pull request #186 from cisagov/improvement/switch_prettier_hook

    Switch the `pre-commit` hook used to run `prettier`
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f0e55b3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    97f40fc View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e452973 View commit details
    Browse the repository at this point in the history
  17. Upgrade bandit to 1.7.10

    We should use the same version of bandit throughout the pre-commit
    configuration.
    jsf9k committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a06c2b9 View commit details
    Browse the repository at this point in the history