-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ CONFLICT! Lineage pull request for: skeleton #34
base: develop
Are you sure you want to change the base?
Commits on Feb 14, 2024
-
Add checks for semantic python versions
Michael Saki committedFeb 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 33582a1 - Browse repository at this point
Copy the full SHA 33582a1View commit details -
Refactor code for the semantic check
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
Michael Saki committedFeb 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 9438194 - Browse repository at this point
Copy the full SHA 9438194View commit details
Commits on Mar 18, 2024
-
Add checks for semantic python versions
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for cea8edc - Browse repository at this point
Copy the full SHA cea8edcView commit details -
Refactor code for the semantic check
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for d5c7c4a - Browse repository at this point
Copy the full SHA d5c7c4aView commit details -
Merge branch 'improvement/correct-semantic-python-version-checks' of h…
…ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for f7b9d05 - Browse repository at this point
Copy the full SHA f7b9d05View commit details -
Remove example of correct semantic version
Michael Saki committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 327ab73 - Browse repository at this point
Copy the full SHA 327ab73View commit details
Commits on Mar 20, 2024
-
Refactor the error message for the user
Michael Saki committedMar 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 4dedf50 - Browse repository at this point
Copy the full SHA 4dedf50View commit details -
Improve the semantic error message
Michael Saki committedMar 20, 2024 Configuration menu - View commit details
-
Copy full SHA for e84deea - Browse repository at this point
Copy the full SHA e84deeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fdc7be - Browse repository at this point
Copy the full SHA 5fdc7beView commit details
Commits on Mar 21, 2024
-
Refactor regex, add link, and improve comments
Michael Saki committedMar 21, 2024 Configuration menu - View commit details
-
Copy full SHA for 42ef8c2 - Browse repository at this point
Copy the full SHA 42ef8c2View commit details -
Update link to use semver.org over regex101.com
Michael Saki committedMar 21, 2024 Configuration menu - View commit details
-
Copy full SHA for a77e5e1 - Browse repository at this point
Copy the full SHA a77e5e1View commit details -
Co-authored-by: dav3r <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5fe14c7 - Browse repository at this point
Copy the full SHA 5fe14c7View commit details
Commits on Apr 20, 2024
-
Add a meta hook to the pre-commit configuration
Add the `check-useless-excludes` meta hook to verify that any defined `exclude` directives apply to at least one file in the repository.
Configuration menu - View commit details
-
Copy full SHA for b7896a0 - Browse repository at this point
Copy the full SHA b7896a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 260566f - Browse repository at this point
Copy the full SHA 260566fView commit details
Commits on May 21, 2024
-
Pin ansible-core when running the ansible-lint linter
New versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected. Co-authored-by: Nick <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 07e2b60 - Browse repository at this point
Copy the full SHA 07e2b60View commit details -
The line is not only unnecessary, it was commented out to boot!
Configuration menu - View commit details
-
Copy full SHA for c74e5db - Browse repository at this point
Copy the full SHA c74e5dbView commit details -
Explain why ansible may need to be added as a dependency for ansible-…
…lint On its own ansible-lint does not pull in ansible, only ansible-core. Therefore, if an Ansible module lives in ansible instead of ansible-core, the linter will complain that the module is unknown. In these cases it is necessary to add the ansible package itself as an additional dependency, with the same pinning as is done in requirements-test.txt of cisagov/skeleton-ansible-role.
Configuration menu - View commit details
-
Copy full SHA for 2e53e0d - Browse repository at this point
Copy the full SHA 2e53e0dView commit details
Commits on Jun 6, 2024
-
Update pre-commit hook versions
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier was manually held back because the latest tags are for alpha releases of the next major version.
Configuration menu - View commit details
-
Copy full SHA for f51fe62 - Browse repository at this point
Copy the full SHA f51fe62View commit details -
Manually update the prettier hook
Use the latest v3 release available from NPM.
Configuration menu - View commit details
-
Copy full SHA for 8e55b8e - Browse repository at this point
Copy the full SHA 8e55b8eView commit details -
Correct commented-out ansible pin
The pin now agrees with what is in cisagov/skeleton-ansible-role. Co-authored-by: Nick <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c617bb9 - Browse repository at this point
Copy the full SHA c617bb9View commit details -
Merge pull request #183 from cisagov/maintenance/update_pre-commit_hooks
Update `pre-commit` hooks
Configuration menu - View commit details
-
Copy full SHA for de92c3c - Browse repository at this point
Copy the full SHA de92c3cView commit details -
Merge pull request #182 from cisagov/improvement/pin-packages-for-ans…
…ible-lint Pin packages for `ansible-lint`
Configuration menu - View commit details
-
Copy full SHA for 7ddea47 - Browse repository at this point
Copy the full SHA 7ddea47View commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a68994d - Browse repository at this point
Copy the full SHA a68994dView commit details
Commits on Aug 12, 2024
-
Use the hashicorp/setup-packer GitHub Action
Instead of manually installing Packer we can instead leverage the hashicorp/setup-packer Action just as we do for Terraform.
Configuration menu - View commit details
-
Copy full SHA for 43b91c7 - Browse repository at this point
Copy the full SHA 43b91c7View commit details
Commits on Aug 23, 2024
-
Remove @jasonodoom as a codeowner
He is no longer a member of @cisagov/vm-dev.
Configuration menu - View commit details
-
Copy full SHA for 8ada75d - Browse repository at this point
Copy the full SHA 8ada75dView commit details
Commits on Aug 26, 2024
-
Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general. The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version. Co-authored-by: Nick <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2930208 - Browse repository at this point
Copy the full SHA 2930208View commit details
Commits on Sep 24, 2024
-
Bump actions/cache from 3 to 4
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46e0553 - Browse repository at this point
Copy the full SHA 46e0553View commit details -
Bump crazy-max/ghaction-github-status from 3 to 4
Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4. - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases) - [Commits](crazy-max/ghaction-github-status@v3...v4) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-status dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3167421 - Browse repository at this point
Copy the full SHA 3167421View commit details
Commits on Sep 25, 2024
-
Update pre-commit hook versions
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier hook was manually held back because the latest tags are for alpha releases of the next major version.
Configuration menu - View commit details
-
Copy full SHA for 6a58c2c - Browse repository at this point
Copy the full SHA 6a58c2cView commit details -
Manually update the prettier hook
Use the latest v3 release available from NPM.
Configuration menu - View commit details
-
Copy full SHA for 553efcb - Browse repository at this point
Copy the full SHA 553efcbView commit details -
Merge pull request #170 from cisagov/dependabot/github_actions/crazy-…
…max/ghaction-github-status-4 Bump crazy-max/ghaction-github-status from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for 184e749 - Browse repository at this point
Copy the full SHA 184e749View commit details -
Merge pull request #171 from cisagov/dependabot/github_actions/action…
…s/cache-4 Bump actions/cache from 3 to 4
Configuration menu - View commit details
-
Copy full SHA for d99c117 - Browse repository at this point
Copy the full SHA d99c117View commit details -
Merge pull request #187 from cisagov/improvement/use_setup_packer_action
Use an Action to install Packer in our GitHub Actions workflows
Configuration menu - View commit details
-
Copy full SHA for 2491ca0 - Browse repository at this point
Copy the full SHA 2491ca0View commit details -
Merge pull request #176 from cisagov/improvement/correct-semantic-pyt…
…hon-version-checks Add checks for correct semantic version of Python
Configuration menu - View commit details
-
Copy full SHA for f6c9537 - Browse repository at this point
Copy the full SHA f6c9537View commit details -
Merge pull request #188 from cisagov/remove-odoom-as-a-codeowner
Remove @jasonodoom as a codeowner
Configuration menu - View commit details
-
Copy full SHA for 10e5f6f - Browse repository at this point
Copy the full SHA 10e5f6fView commit details -
Add a pre-commit hook to run pip-audit
The pip-audit tool will audit any supplied pip requirements files for vulnerable packages.
Configuration menu - View commit details
-
Copy full SHA for 045a998 - Browse repository at this point
Copy the full SHA 045a998View commit details -
Merge pull request #178 from cisagov/improvement/add_pre-commit_meta_…
…hook Add the `check-useless-excludes` hook to the pre-commit configuration
Configuration menu - View commit details
-
Copy full SHA for 28dc4ce - Browse repository at this point
Copy the full SHA 28dc4ceView commit details -
Merge pull request #179 from cisagov/improvement/add_pip-audit_pre-co…
…mmit_hook Add a pre-commit hook to run `pip-audit`
Configuration menu - View commit details
-
Copy full SHA for 5801cec - Browse repository at this point
Copy the full SHA 5801cecView commit details -
Merge pull request #184 from cisagov/improvement/pin-flake8-docstrings
Add a lower-bound pin for the `flake8-docstrings` `pip` package
Configuration menu - View commit details
-
Copy full SHA for e61255c - Browse repository at this point
Copy the full SHA e61255cView commit details -
Merge pull request #185 from cisagov/maintenance/update_pre-commit_hooks
Update `pre-commit` hooks
Configuration menu - View commit details
-
Copy full SHA for 44cd1be - Browse repository at this point
Copy the full SHA 44cd1beView commit details -
Use the rbubley/mirrors-prettier hook for prettier
This replaces the now archived pre-commit/mirrors-prettier hook.
Configuration menu - View commit details
-
Copy full SHA for c502f1a - Browse repository at this point
Copy the full SHA c502f1aView commit details -
Merge pull request #186 from cisagov/improvement/switch_prettier_hook
Switch the `pre-commit` hook used to run `prettier`
Configuration menu - View commit details
-
Copy full SHA for f0e55b3 - Browse repository at this point
Copy the full SHA f0e55b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97f40fc - Browse repository at this point
Copy the full SHA 97f40fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e452973 - Browse repository at this point
Copy the full SHA e452973View commit details -
We should use the same version of bandit throughout the pre-commit configuration.
Configuration menu - View commit details
-
Copy full SHA for a06c2b9 - Browse repository at this point
Copy the full SHA a06c2b9View commit details