-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile configuration #195
base: develop
Are you sure you want to change the base?
Commits on Feb 19, 2024
-
Use the full identifier for source Docker images
This helps ensure that when a Docker image is built the expacted source image is used regardless of what repository is configured as the default on the host system. It also makes our Dockerfiles more seamlessly convertible to using the GitHub Container Registry or any other Open Container Initiative (OCI) compatible registry.
Configuration menu - View commit details
-
Copy full SHA for a1b9e94 - Browse repository at this point
Copy the full SHA a1b9e94View commit details -
Use a specific version of Alpine Linux
Use the full tag that includes the Alpine Linux version to ensure the pulled image is always the same.
Configuration menu - View commit details
-
Copy full SHA for bac905d - Browse repository at this point
Copy the full SHA bac905dView commit details
Commits on Feb 20, 2024
-
Merge pull request #187 from cisagov/improvement/use_full_image_source
Use the full path for source container images
Configuration menu - View commit details
-
Copy full SHA for ce1247a - Browse repository at this point
Copy the full SHA ce1247aView commit details -
Install cisagov/skeleton-python-library directly
Instead of downloading the source archive, extracting it, and then installing it with pip we instead just let pip directly install the package.
Configuration menu - View commit details
-
Copy full SHA for 5088fdc - Browse repository at this point
Copy the full SHA 5088fdcView commit details -
Remove unused OS package dependencies
Since we are now installing cisagov/skeleton-python-library directly with pip we no longer need these OS packages.
Configuration menu - View commit details
-
Copy full SHA for 22aa084 - Browse repository at this point
Copy the full SHA 22aa084View commit details -
Change the secret message being checks in tests
Now that we are not overwriting the internal Python package file the text we look for must match what is output by default. The Docker Compose secret configuration is left in place to continue to serve as an example and to be leveraged for a future update to cisagov/skeleton-python-library that can provide similar functionality to what was removed in this project.
Configuration menu - View commit details
-
Copy full SHA for 66032ea - Browse repository at this point
Copy the full SHA 66032eaView commit details
Commits on Feb 21, 2024
-
Merge pull request #188 from cisagov/improvement/install_skeleton-pyt…
…hon-library_directly Install cisagov/skeleton-python-library directly with `pip`
Configuration menu - View commit details
-
Copy full SHA for aa39972 - Browse repository at this point
Copy the full SHA aa39972View commit details
Commits on Feb 23, 2024
-
We should not blindly upgrade all pre-installed packages. This can create inconsistent build results due to changes in installed versions.
Configuration menu - View commit details
-
Copy full SHA for 6b36d69 - Browse repository at this point
Copy the full SHA 6b36d69View commit details -
Pin Python packages directly installed
Pin the versions of the pip, setuptools, and wheel packages that are installed.
Configuration menu - View commit details
-
Copy full SHA for 45f104a - Browse repository at this point
Copy the full SHA 45f104aView commit details -
We can move this instruction to the end of the Dockerfile now that we are no longer working with files in the Docker container when building.
Configuration menu - View commit details
-
Copy full SHA for 446c9b5 - Browse repository at this point
Copy the full SHA 446c9b5View commit details
Commits on Feb 26, 2024
-
Merge pull request #189 from cisagov/improvement/make_builds_more_rep…
…eatable Pin Python package versions and improve build repeatability
Configuration menu - View commit details
-
Copy full SHA for 0a49b3e - Browse repository at this point
Copy the full SHA 0a49b3eView commit details -
Prefer calling pip as a module
Instead of relying on `pip3` being on the PATH we instead call the module through the Python executable. This ensures that the `pip` being used is in the same environment as the `python3` being used.
Configuration menu - View commit details
-
Copy full SHA for 8534e1d - Browse repository at this point
Copy the full SHA 8534e1dView commit details -
Use a Python virtual environment in the Docker image
Using a virtual environment is a Python best practice. We also consolidate all of the Python dependency installation steps into a single RUN instruction. This ensures that Python setup is cached in one layer and mirrors the logical organization of this being a single step.
Configuration menu - View commit details
-
Copy full SHA for 8113726 - Browse repository at this point
Copy the full SHA 8113726View commit details
Commits on Feb 27, 2024
-
Since we cannot use long options on Alpine Linux we should explain what the short options we are using do. I also changed the order of options so that they are in alphabetical order. Co-authored-by: Shane Frasier <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 77b5e34 - Browse repository at this point
Copy the full SHA 77b5e34View commit details -
Merge pull request #190 from cisagov/improvement/use_Python_venv
Use a Python virtual environment
Configuration menu - View commit details
-
Copy full SHA for 35e8753 - Browse repository at this point
Copy the full SHA 35e8753View commit details
Commits on Feb 28, 2024
-
This configuration includes a Pipfile configuration file and the generated Pipfile.lock file that pins to specific versions for the Python dependencies for this project. This will help us ensure repeatable builds. The pipenv package is added as a developmental requirement to support these files.
Configuration menu - View commit details
-
Copy full SHA for 2266949 - Browse repository at this point
Copy the full SHA 2266949View commit details -
Install Python dependencies using pipenv
Now that we have a pipenv configuration we will use it to install the Python dependencies for the image. The `build` workflow is updated to no longer pass the VERSION build argument in line with this change.
Configuration menu - View commit details
-
Copy full SHA for d530d07 - Browse repository at this point
Copy the full SHA d530d07View commit details -
Use a multi-stage Docker build
Switch to using a multi-stage build in the Dockerfile. This reduces image size since pipenv and its dependencices are not needed in the final image. It also ensures that the system Python environment is unmodified.
Configuration menu - View commit details
-
Copy full SHA for adfcfdb - Browse repository at this point
Copy the full SHA adfcfdbView commit details -
Install core Python packages into the system Python environment
Install the core Python packages (pip, setuptools, and wheel) into the system Python environment before installing pipenv. This keeps things consistent with our usual approach to Python environments.
Configuration menu - View commit details
-
Copy full SHA for 8e03ad9 - Browse repository at this point
Copy the full SHA 8e03ad9View commit details -
Fix outdated comment in the Dockerfile
The comment references a command that is no longer being run. Co-authored-by: Shane Frasier <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c45345f - Browse repository at this point
Copy the full SHA c45345fView commit details -
Fix typo in Dockerfile comment
Co-authored-by: dav3r <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d42ae8f - Browse repository at this point
Copy the full SHA d42ae8fView commit details -
Merge pull request #191 from cisagov/improvement/pin_Python_configura…
…tion Install Python dependencies with `pipenv`
Configuration menu - View commit details
-
Copy full SHA for 1b3e9d8 - Browse repository at this point
Copy the full SHA 1b3e9d8View commit details
Commits on Feb 29, 2024
-
Update image tag information in the README
Change the tags used in the table to match the version of the project. Previously "1.2.3" was used as an example version but there is no reason not to use the real version of the image.
Configuration menu - View commit details
-
Copy full SHA for 2811690 - Browse repository at this point
Copy the full SHA 2811690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a601fe - Browse repository at this point
Copy the full SHA 5a601feView commit details
Commits on Mar 4, 2024
-
Merge pull request #192 from cisagov/improvement/update_readme
Update the README
Configuration menu - View commit details
-
Copy full SHA for 6d487cf - Browse repository at this point
Copy the full SHA 6d487cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d7cc8f - Browse repository at this point
Copy the full SHA 0d7cc8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b28481f - Browse repository at this point
Copy the full SHA b28481fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fff262b - Browse repository at this point
Copy the full SHA fff262bView commit details -
Bump cisagov/skeleton-python-library from 0.0.1 to 0.2.0
Update the Dockerfile and testing to accommodate changes in the new version.
Configuration menu - View commit details
-
Copy full SHA for dd7d982 - Browse repository at this point
Copy the full SHA dd7d982View commit details
Commits on Mar 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e054517 - Browse repository at this point
Copy the full SHA e054517View commit details -
Merge pull request #193 from cisagov/improvement/update_dependencies
Update dependencies
Configuration menu - View commit details
-
Copy full SHA for d2c1ba2 - Browse repository at this point
Copy the full SHA d2c1ba2View commit details
Commits on Mar 13, 2024
-
Correct usage of the term "symlink"
Co-authored-by: dav3r <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae46c28 - Browse repository at this point
Copy the full SHA ae46c28View commit details