Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #196

Open
wants to merge 153 commits into
base: develop
Choose a base branch
from

Commits on Sep 13, 2023

  1. Bump crazy-max/ghaction-github-status from 3 to 4

    Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4.
    - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases)
    - [Commits](crazy-max/ghaction-github-status@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: crazy-max/ghaction-github-status
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    b5e5c11 View commit details
    Browse the repository at this point in the history
  2. Add a diagnostics job for the label syncing workflow

    Also add a runner hardening task to the labeler job.
    jsf9k committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    371179e View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    1f611fc View commit details
    Browse the repository at this point in the history
  2. Make dev team members the codeowners of the requirements*.txt and set…

    …up-env files
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c356768 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Explicitly list the linter config files the dev team should own

    @mcdonnnj correctly pointed out that other projects add their own
    configuration files that match, e.g., the /.*.yaml pattern.  We want
    to ensure that we only own the linter configuration files from the
    skeleton.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0195005 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Bump hashicorp/setup-terraform from 2 to 3

    Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 2 to 3.
    - [Release notes](https://github.com/hashicorp/setup-terraform/releases)
    - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md)
    - [Commits](hashicorp/setup-terraform@v2...v3)
    
    ---
    updated-dependencies:
    - dependency-name: hashicorp/setup-terraform
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b768a28 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Prefer block style to flow style

    We prefer block style to flow style for sequences and mappings in YAML.
    mcdonnnj committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9f31700 View commit details
    Browse the repository at this point in the history
  2. Alphabetize entries in the build workflow

    We prefer to alphabetize mapping keys in YAML documents whenever
    possible.
    mcdonnnj committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    696433a View commit details
    Browse the repository at this point in the history
  3. Add a merge_group trigger to the build workflow

    This should improve compatibility with merge queues. We configure it to
    only trigger on the `checks_requested` type which is currently the only
    supported type for this trigger. If additional types are added in the
    future they should be added if appropriate.
    mcdonnnj committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6503a9e View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Bump actions/setup-go from 4 to 5

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    193e799 View commit details
    Browse the repository at this point in the history
  2. Bump actions/setup-python from 4 to 5

    Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
    - [Release notes](https://github.com/actions/setup-python/releases)
    - [Commits](actions/setup-python@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-python
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5c84295 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Switch pre-commit hooks for running shfmt

    This hook bundles the binaries for shfmt with a Python package which
    removes the need to manually install the tool for the hook to function.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4a63dbe View commit details
    Browse the repository at this point in the history
  2. Remove installation of shfmt in the build workflow

    The new pre-commit hook provides `shfmt` binaries so we no longer need
    to ensure it is installed.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3236b1b View commit details
    Browse the repository at this point in the history
  3. Use long options for shfmt arguments

    Since shfmt now supports long command line options we should use them
    as that is our preference. The single quotes for the number of spaces
    to indent is changed to double quotes to align with our usual quotation
    style.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    5ddb14d View commit details
    Browse the repository at this point in the history
  4. Add additional shfmt options

    These options are baked into the functionality of the old hook but must
    be explicitly declared for the new hook.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8ecd957 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Set the default shell for all run steps in the build workflow

    This sets the default shell for any run steps in the build workflow to
    mirror our standard shellscript writing practices. In addition to
    enabling our standard options it will also enable errtrace and print
    any commands that are run which should make debugging/troubleshooting
    more straightforward.
    mcdonnnj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    242921b View commit details
    Browse the repository at this point in the history
  2. Add linting with goimports to the pre-commit configuration

    This will run the Go tool `goimports` against the repository if it
    contains any Go files. This tool bundles the functionality of `go fmt`
    with the additional benefit of sorting Go imports much like the isort
    tool we use for Python code.
    mcdonnnj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c7b18dc View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Add ATX Header Support for terraform-docs

    This is a temporary fix until @mcdonnnj has
    his PR approved and merged into the terraform-docs
    repo. This fix will perform a shallow clone of his
    forked branch, build the binary, and install it.
    Michael Saki committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f6d9d6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    544e478 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary capitalizations and fix grammar

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f5fa0ff View commit details
    Browse the repository at this point in the history
  4. Simplify steps in the build/install portion of workflow

    PATH is handled by `setup-go` so we can refactor the code setting it. Also we are taking advantage of the -C switch to handle building from the cloned repository.
    
    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    36361dd View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Add TODO label

    michaelsaki authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3711ebe View commit details
    Browse the repository at this point in the history
  2. Move TODO and add link to the issue

    `TODO` was placed on the wrong comment block. Also I am adding a link to the issue for the TODO.
    michaelsaki authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d114fb4 View commit details
    Browse the repository at this point in the history
  3. Alphabetize switches

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c907cfc View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Allow setup-env to specify Python version

    This commit is introducing 2 new flags
    into the setup-env script. -l or
    --list-versions will list available
    Python versions and allow the user to
    select a version interactively. The second
    flag -v or --version will allow a user
    to set the version if installed.
    (e.g. ./setup-env -v 3.9.6)
    Michael Saki committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    48db3e3 View commit details
    Browse the repository at this point in the history
  2. Add /dev/null and remove TMPFILE

    This makes the code a bit cleaner and still accomplishes the same functionality
    
    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c10929a View commit details
    Browse the repository at this point in the history
  3. Place flags in the correct order for -r and -p

    Michael Saki committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    adada40 View commit details
    Browse the repository at this point in the history
  4. Remove unneccessary spacing

    Michael Saki committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1861b9b View commit details
    Browse the repository at this point in the history
  5. Alphabetize flags and descriptions

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3f623e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Move misplaced exit

    If the Python version exists then we want the script to continue
    execution.
    jsf9k committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9497dc2 View commit details
    Browse the repository at this point in the history
  2. Remove premature pyenv local command

    pyenv local is run below.
    jsf9k committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e1d0f28 View commit details
    Browse the repository at this point in the history
  3. Include PYTHON_VERSION when running pyenv virtualenv

    If PYTHON_VERSION is an empty string then the system Python will be used.
    jsf9k committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    517b336 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Add getopt variables and short flags

    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2e5794c View commit details
    Browse the repository at this point in the history
  2. Remove redundant flag initialization

    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8a50031 View commit details
    Browse the repository at this point in the history
  3. Add getopt functionality and -n flag

    This commit makes a couple changes. The first
    change is adding the BSD getopt tool to
    simplify the parsing of flags and arguments.
    Second, we are adding the -n flag so the user
    can specify the name of the virtual environment
    if they choose.
    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0df0e6a View commit details
    Browse the repository at this point in the history
  4. Update the usage and force documentation

    This commit will update the usage documentation
    so now it will display all the new flags, how
    to use them, and what they do. Since the
    long option isn't available for the BSD version
    of getopt we have to use short options only.
    The force documentation has been updated to
    reflect this change. Also removed some redundant
    code that wasn't necessary.
    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    60cad12 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Update usage with long options

    Michael Saki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b6ab6d8 View commit details
    Browse the repository at this point in the history
  2. Add gnu-getopt functionality and error handling

    This commit will make it so long options are
    supported. It also includes some improved
    error handling. It will display a message if
    a Mac OS user doesn't have gnu-getopt installed
    on their system and suggest steps to take to
    get it installed via brew.
    Michael Saki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d362614 View commit details
    Browse the repository at this point in the history
  3. Add documentation in CONTRIBUTING.md for gnu-getopt

    Michael Saki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f924584 View commit details
    Browse the repository at this point in the history
  4. Fix grammar and capitalization errors

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ba86ead View commit details
    Browse the repository at this point in the history
  5. Combine PATH exports to single line

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ba0fc19 View commit details
    Browse the repository at this point in the history
  6. Improve usage instructions

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1240bdd View commit details
    Browse the repository at this point in the history
  7. Add $(brew --prefix) to PATH for getopt

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    297b5bd View commit details
    Browse the repository at this point in the history
  8. Fix confusing wording

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7af70f5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e5a2d14 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Differentiate between GNU getopt and gnu-getopt brew formula

    This commit will clearly differentiate between GNU getopt the tool and gnu-getopt the Homebrew formula. Also updating the URL so that getopt points at the source repository and pyenv and pyenv-virtualenv point at their respective repositories. Updated the ending punctuation.
    
    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    82c70e0 View commit details
    Browse the repository at this point in the history
  2. Add parenthesis over brew link

    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    493a4a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Refactor flag names for clarity and accuracy

    This commit will remove the previous flags
    -v or --version for -p or --python-version.
    Also it will replace -n or --name for -v or
    --venv-name. The usage menu has been updated
    to reflect these changes as well.
    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3bc9aeb View commit details
    Browse the repository at this point in the history
  2. Elaborate on message when checking for GNU getopt

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0be1f63 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary nounset flipping logic

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c8f0b1b View commit details
    Browse the repository at this point in the history
  4. Separate pyenv PATH from GNU getopt PATH

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    495862a View commit details
    Browse the repository at this point in the history
  5. Add checks for semantic python versions

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    33582a1 View commit details
    Browse the repository at this point in the history
  6. Refactor code for the semantic check

    This commit will make a few changes. The
    orginal version of the semantic checking
    function was a bit more difficult to read.
    It is now somewhat easier to follow how
    the regex is structured. Also the function
    has been renamed to check_python_version
    since it has 2 functions, making sure that
    the version is semantically correct and the
    second is to make sure that it is installed
    on the user's machine. This makes it easier
    to follow the logic for the flags, -p or
    --python-version and -l or --list-versions
    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    9438194 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Improve verbiage in comments

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4752b37 View commit details
    Browse the repository at this point in the history
  2. Clarify between pyenv and GNU getopt setup

    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2e38997 View commit details
    Browse the repository at this point in the history
  3. Improve comment on conditional check for regex

    Michael Saki committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f8824c8 View commit details
    Browse the repository at this point in the history
  4. Add comment explaining that GNU getopt is keg-only

    Michael Saki committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    88724e7 View commit details
    Browse the repository at this point in the history
  5. Improve comments to better describe keg-only terminology

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c1870be View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Configuration menu
    Copy the full SHA
    a3f69cd View commit details
    Browse the repository at this point in the history
  2. Remove build-in error exit for generic error exit

    Exit code 2 usually relates to build-ins which does not fit what is failing here. Not sure what alternative would be best so we can just use the generic failure code
    
    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8ff5179 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c21e2b View commit details
    Browse the repository at this point in the history
  4. Check for pyenv earlier in the script

    Since the new function, python_versions expects
    pyenv to be installed it makes sense to have it
    checked earlier in the script.
    Michael Saki committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3acc8d6 View commit details
    Browse the repository at this point in the history
  5. Explain -r and -p in Python version prompt

    Michael Saki committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b377ce7 View commit details
    Browse the repository at this point in the history
  6. Refine exit code to 64 with gnu-getopt note

    - Set exit code to 64 per sysexits.h for clarity.
    - Added comment on gnu-getopt handling.
    
    Aligns with Unix standards and enhances readability.
    Michael Saki committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    74838a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Rename gnu-getopt tool to GNU getopt formula

    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    487126e View commit details
    Browse the repository at this point in the history
  2. Fix whitespace for usage menu

    Co-authored-by: Shane Frasier <[email protected]>
    michaelsaki and jsf9k authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6c82a8d View commit details
    Browse the repository at this point in the history
  3. Add link to brew terminology

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    324f6d4 View commit details
    Browse the repository at this point in the history
  4. Rephrase comment to improve clarity

    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a26d0e3 View commit details
    Browse the repository at this point in the history
  5. Improve comment for clarity

    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0510870 View commit details
    Browse the repository at this point in the history
  6. Improve verbiage in comment

    Michael Saki committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    01abde6 View commit details
    Browse the repository at this point in the history
  7. Change comments for macOS and venv_name

    Michael Saki committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0989d17 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Improve comments for clarity

    Co-authored-by: Nick <[email protected]>
    michaelsaki and mcdonnnj authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a9c6ed8 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b9c729f View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    The hook is manually updated to the last v3 tag available from the
    pre-commit/mirrors-prettier repository. We then add the latest release
    of v3 available from NPM as an additional depdency.
    mcdonnnj committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4c93395 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge pull request #149 from cisagov/dependabot/github_actions/crazy-…

    …max/ghaction-github-status-4
    
    Bump crazy-max/ghaction-github-status from 3 to 4
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9a0e7c3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #150 from cisagov/improvement/add-diagnostics-to-l…

    …abel-sync-workflow
    
    Add a diagnostics job for the label syncing workflow
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d0d8783 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #151 from cisagov/improvement/make-ois-own-linting…

    …-configs
    
    Make the dev team the owners of the linter configuration files
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    158abf5 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #155 from cisagov/dependabot/github_actions/hashic…

    …orp/setup-terraform-3
    
    Bump hashicorp/setup-terraform from 2 to 3
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6f23c97 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #156 from cisagov/improvement/better_support_merge…

    …_queues
    
    Improve merge queue support
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c0043bd View commit details
    Browse the repository at this point in the history
  6. Merge pull request #158 from cisagov/dependabot/github_actions/action…

    …s/setup-go-5
    
    Bump actions/setup-go from 4 to 5
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e5ffc52 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #159 from cisagov/dependabot/github_actions/action…

    …s/setup-python-5
    
    Bump actions/setup-python from 4 to 5
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    59b2ad1 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #161 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hooks
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    57bef4a View commit details
    Browse the repository at this point in the history
  9. Merge pull request #162 from cisagov/improvement/set_default_for_run_…

    …steps
    
    Set the default `shell` for all `run` steps in the `build` workflow
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    01c9e11 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #166 from cisagov/improvement/allow_setup-env_to_s…

    …pecify_python
    
    Allow setup-env to specify Python version
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d1a186d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7169dcf View commit details
    Browse the repository at this point in the history
  12. Merge pull request #157 from cisagov/improvement/get_more_versions_fr…

    …om_action
    
    Use `cisagov/setup-env-github-action` to provide the Python and Go versions to use
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    95a61f5 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #160 from cisagov/improvement/switch_pre-commit_ho…

    …ok_for_shfmt
    
    Switch the pre-commit hook used to run `shfmt`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    81735c2 View commit details
    Browse the repository at this point in the history
  14. Merge pull request #163 from cisagov/improvement/add_goimports_hook

    Add a pre-commit hook to run `goimports`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4f73489 View commit details
    Browse the repository at this point in the history
  15. Merge pull request #164 from cisagov/improvement/install_atx_header_s…

    …upport_terraform-docs
    
    Add ATX Header Support for `terraform-docs`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9020b55 View commit details
    Browse the repository at this point in the history
  16. Switch pre-commit hooks for running shellcheck

    This hook bundles the binaries for shellcheck with a Python package
    which removes the need to ensure the tool is installed for the hook to
    function. It also ties the version of shellcheck used to the hook which
    will help guarantee consistency.
    mcdonnnj committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    035cf86 View commit details
    Browse the repository at this point in the history
  17. Merge pull request #168 from cisagov/improvement/switch_pre-commit_ho…

    …ok_for_shellcheck
    
    Switch the pre-commit hook used to run `shellcheck`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e79569c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Add checks for semantic python versions

    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cea8edc View commit details
    Browse the repository at this point in the history
  2. Refactor code for the semantic check

    This commit will make a few changes. The
    orginal version of the semantic checking
    function was a bit more difficult to read.
    It is now somewhat easier to follow how
    the regex is structured. Also the function
    has been renamed to check_python_version
    since it has 2 functions, making sure that
    the version is semantically correct and the
    second is to make sure that it is installed
    on the user's machine. This makes it easier
    to follow the logic for the flags, -p or
    --python-version and -l or --list-versions
    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d5c7c4a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'improvement/correct-semantic-python-version-checks' of h…

    …ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f7b9d05 View commit details
    Browse the repository at this point in the history
  4. Remove example of correct semantic version

    Michael Saki committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    327ab73 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Refactor the error message for the user

    Michael Saki committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4dedf50 View commit details
    Browse the repository at this point in the history
  2. Improve the semantic error message

    Michael Saki committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e84deea View commit details
    Browse the repository at this point in the history
  3. Fix grammar

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5fdc7be View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Refactor regex, add link, and improve comments

    Michael Saki committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    42ef8c2 View commit details
    Browse the repository at this point in the history
  2. Update link to use semver.org over regex101.com

    Michael Saki committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a77e5e1 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary period

    Co-authored-by: dav3r <[email protected]>
    michaelsaki and dav3r authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5fe14c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Add a meta hook to the pre-commit configuration

    Add the `check-useless-excludes` meta hook to verify that any defined
    `exclude` directives apply to at least one file in the repository.
    mcdonnnj committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    b7896a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    260566f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Pin ansible-core when running the ansible-lint linter

    New versions of ansible-core (2.16.7 and 2.17.0) have been released
    that do not suffer from the bug discussed in ansible/ansible#82702.
    This bug broke any symlinked files in vars, tasks, etc. for any
    Ansible role installed via ansible-galaxy.
    
    All versions later than ansible-core 2.16.7 and 2.17.0 should function
    as expected.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj committed May 21, 2024
    Configuration menu
    Copy the full SHA
    07e2b60 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary line

    The line is not only unnecessary, it was commented out to boot!
    jsf9k committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c74e5db View commit details
    Browse the repository at this point in the history
  3. Explain why ansible may need to be added as a dependency for ansible-…

    …lint
    
    On its own ansible-lint does not pull in ansible, only ansible-core.
    Therefore, if an Ansible module lives in ansible instead of
    ansible-core, the linter will complain that the module is unknown.  In
    these cases it is necessary to add the ansible package itself as an
    additional dependency, with the same pinning as is done in
    requirements-test.txt of cisagov/skeleton-ansible-role.
    jsf9k committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2e53e0d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f51fe62 View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    Use the latest v3 release available from NPM.
    mcdonnnj committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8e55b8e View commit details
    Browse the repository at this point in the history
  3. Correct commented-out ansible pin

    The pin now agrees with what is in cisagov/skeleton-ansible-role.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c617bb9 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #183 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hooks
    mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    de92c3c View commit details
    Browse the repository at this point in the history
  5. Merge pull request #182 from cisagov/improvement/pin-packages-for-ans…

    …ible-lint
    
    Pin packages for `ansible-lint`
    mcdonnnj authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7ddea47 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    a68994d View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Use the hashicorp/setup-packer GitHub Action

    Instead of manually installing Packer we can instead leverage the
    hashicorp/setup-packer Action just as we do for Terraform.
    mcdonnnj committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    43b91c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Remove @jasonodoom as a codeowner

    He is no longer a member of @cisagov/vm-dev.
    jsf9k committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8ada75d View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Pin to a specific version

    Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general.
    
    The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version.
    
    Co-authored-by: Nick <[email protected]>
    jsf9k and mcdonnnj authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2930208 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Bump actions/cache from 3 to 4

    Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    46e0553 View commit details
    Browse the repository at this point in the history
  2. Bump crazy-max/ghaction-github-status from 3 to 4

    Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4.
    - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases)
    - [Commits](crazy-max/ghaction-github-status@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: crazy-max/ghaction-github-status
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3167421 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier hook was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6a58c2c View commit details
    Browse the repository at this point in the history
  2. Manually update the prettier hook

    Use the latest v3 release available from NPM.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    553efcb View commit details
    Browse the repository at this point in the history
  3. Merge pull request #170 from cisagov/dependabot/github_actions/crazy-…

    …max/ghaction-github-status-4
    
    Bump crazy-max/ghaction-github-status from 3 to 4
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    184e749 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #171 from cisagov/dependabot/github_actions/action…

    …s/cache-4
    
    Bump actions/cache from 3 to 4
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d99c117 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #187 from cisagov/improvement/use_setup_packer_action

    Use an Action to install Packer in our GitHub Actions workflows
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2491ca0 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #176 from cisagov/improvement/correct-semantic-pyt…

    …hon-version-checks
    
    Add checks for correct semantic version of Python
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f6c9537 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    10e5f6f View commit details
    Browse the repository at this point in the history
  8. Add a pre-commit hook to run pip-audit

    The pip-audit tool will audit any supplied pip requirements files for
    vulnerable packages.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    045a998 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #178 from cisagov/improvement/add_pre-commit_meta_…

    …hook
    
    Add the `check-useless-excludes` hook to the pre-commit configuration
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    28dc4ce View commit details
    Browse the repository at this point in the history
  10. Merge pull request #179 from cisagov/improvement/add_pip-audit_pre-co…

    …mmit_hook
    
    Add a pre-commit hook to run `pip-audit`
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5801cec View commit details
    Browse the repository at this point in the history
  11. Merge pull request #184 from cisagov/improvement/pin-flake8-docstrings

    Add a lower-bound pin for the `flake8-docstrings` `pip` package
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e61255c View commit details
    Browse the repository at this point in the history
  12. Merge pull request #185 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hooks
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    44cd1be View commit details
    Browse the repository at this point in the history
  13. Use the rbubley/mirrors-prettier hook for prettier

    This replaces the now archived pre-commit/mirrors-prettier hook.
    mcdonnnj committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c502f1a View commit details
    Browse the repository at this point in the history
  14. Merge pull request #186 from cisagov/improvement/switch_prettier_hook

    Switch the `pre-commit` hook used to run `prettier`
    mcdonnnj authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f0e55b3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5d9c8d4 View commit details
    Browse the repository at this point in the history
  16. Upgrade bandit to 1.7.10

    We should use the same version of bandit throughout the pre-commit
    configuration.
    jsf9k committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    433001b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0fa3931 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    54c8dcd View commit details
    Browse the repository at this point in the history
  19. Upgrade instance of actions/setup-python to v5

    Also pull the Python version from steps.setup-env.outputs instead of
    hardcoding it.
    jsf9k committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    438b62f View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Add a new trigger for the sync-labels GitHub Actions workflow

    Add a `workflow_dispatch` trigger so we can manually run the workflow
    if needed.
    mcdonnnj committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    942c0dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a267662 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc7f09e View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Add the GitHubSecurityLab/actions-permissions/monitor Action

    This Action will provide information about the usage of GITHUB_TOKEN in
    the workflow. It should be added to _every_ job in _any_ workflow to
    provide information for analysis.
    mcdonnnj committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    343d2cc View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Restrict permissions of GITHUB_TOKEN

    This changes the default permissions for the GITHUB_TOKEN used in our
    GitHub Actions configuration to the minimum required to successfully
    run.
    mcdonnnj committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8a77a8b View commit details
    Browse the repository at this point in the history
  2. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    mcdonnnj committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3b1d4ef View commit details
    Browse the repository at this point in the history
  3. Sort hook ids in each pre-commit hook entry

    Ensure that all hook ids are sorted alphabetically in each hook entry
    in our pre-commit configuration.
    mcdonnnj committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1d285f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Merge pull request #189 from cisagov/improvement/manually_run_sync-la…

    …bels_workflow
    
    Allow the `sync-labels` workflow to be run manually
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5da1059 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #190 from cisagov/improvement/add_actions-permissi…

    …ons-monitor
    
    Add the `GitHubSecurityLab/actions-permissions/monitor` Action
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ff221ba View commit details
    Browse the repository at this point in the history
  3. Merge pull request #191 from cisagov/improvement/github_tokenn_polp

    Explicitly define permissions of `GITHUB_TOKEN` in our GitHub Actions workflows
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    971602a View commit details
    Browse the repository at this point in the history
  4. Merge pull request #192 from cisagov/maintenance/update_pre-commit_hooks

    Update `pre-commit` hook versions
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bdf8a25 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #193 from cisagov/improvement/add_more_pre-commit_…

    …hooks
    
    Add additional hooks from `pre-commit/pre-commit-hooks`
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6959971 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #194 from cisagov/improvement/ensure_pre-commit_ho…

    …oks_are_sorted
    
    Sort hook ids in each `pre-commit` hook entry
    mcdonnnj authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f517db7 View commit details
    Browse the repository at this point in the history
  7. Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton

    # Conflicts:
    #	.github/dependabot.yml
    mcdonnnj committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d55b684 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Update the commented out dependabot ignore directives

    Add a directive for hashicorp/setup-packer that was missed when it was
    added to the `build` workflow. Add a directive for
    cisagov/setup-env-github-action that is not strictly necessary since we
    currently just pull from the `develop` branch, but is good to have in
    case we were to change that in the future.
    mcdonnnj committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8824475 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #195 from cisagov/bug/add_missing_dependabot_ignore

    Add missing dependabot ignore directives
    mcdonnnj authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e6afb68 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    12871ec View commit details
    Browse the repository at this point in the history