Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python from 3.9-alpine to 3.9.6-alpine #64

Merged
merged 6 commits into from
Aug 27, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 5, 2021

Bumps python from 3.9-alpine to 3.9.6-alpine.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps python from 3.9-alpine to 3.9.6-alpine.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Jul 5, 2021
@jsf9k jsf9k force-pushed the dependabot/docker/python-3.9.6-alpine branch from 4c43079 to 52fb946 Compare July 7, 2021 18:23
@jsf9k
Copy link
Member

jsf9k commented Jul 7, 2021

The Docker images tagged with 3.9.6-alpine do not contain ppc64le or s390x builds, which I believe is why this build is failing. I'm not sure if that was an oversight on their part or a conscious decision. It does disagree with the documentation for the python Docker image.

@jsf9k
Copy link
Member

jsf9k commented Jul 9, 2021

The Docker images tagged with 3.9.6-alpine do not contain ppc64le or s390x builds, which I believe is why this build is failing. I'm not sure if that was an oversight on their part or a conscious decision. It does disagree with the documentation for the python Docker image.

Digging into this a bit more, I can see that there were some failures the last time these Docker images were built.

(I found the Jenkins page by going to the Docker Hub page for the owner of the python AMIs and clicking on the link for his or her homepage.)

I will wait for the next successful build for the 3.9.6-alpine3.14 tag before trying to re-run the GitHub Actions for this repository, unless @cisagov/team-ois has any other thoughts.

@jsf9k jsf9k unassigned felddy and dav3r Jul 9, 2021
@jsf9k
Copy link
Member

jsf9k commented Jul 13, 2021

I will wait for the next successful build for the 3.9.6-alpine3.14 tag before trying to re-run the GitHub Actions for this repository, unless @cisagov/team-ois has any other thoughts.

The builds are still failing. The last successful builds for ppc64le and s390x are from June 25.

@jsf9k
Copy link
Member

jsf9k commented Jul 22, 2021

It looks like the ppc64le build is now passing, although it has not yet been pushed up to Docker Hub. Perhaps that will happen after all Docker images in the Jenkins link have built.

There is also a s390x build running now that I am following closely.

@jsf9k
Copy link
Member

jsf9k commented Jul 22, 2021

It looks like the ppc64le build is now passing, although it has not yet been pushed up to Docker Hub. Perhaps that will happen after all Docker images in the Jenkins link have built.

Confirmed that all the Docker images were built and the ppc64le Docker image was pushed up to Docker Hub.

@jsf9k
Copy link
Member

jsf9k commented Jul 25, 2021

@felddy, do we really care about supporting the discontinued-for-the-past-20+-years System/390 architecture? I'm inclined to dump support for now and add an issue to remind us to reintegrate it if it returns.

jsf9k added a commit that referenced this pull request Jul 25, 2021
This makes it easier to temporarily drop support for a failing platform
that we cannot fix, as we are currently experiencing  with
#64.
jsf9k added a commit that referenced this pull request Jul 25, 2021
This makes it easier to temporarily drop support for a failing platform
that we cannot fix, as we are currently experiencing  with
#64.

Co-authored-by: Nick M <[email protected]>
@jsf9k
Copy link
Member

jsf9k commented Jul 25, 2021

@felddy, do we really care about supporting the discontinued-for-the-past-20+-years System/390 architecture? I'm inclined to dump support for now and add an issue to remind us to reintegrate it if it returns.

@felddy - See also #67, which provides a way to work around the failing platform.

@jsf9k
Copy link
Member

jsf9k commented Aug 3, 2021

@felddy, do we really care about supporting the discontinued-for-the-past-20+-years System/390 architecture? I'm inclined to dump support for now and add an issue to remind us to reintegrate it if it returns.

@felddy - See also #67, which provides a way to work around the failing platform.

@felddy - Bumping this comment in hopes of getting a response to the issue described in this PR.

@dav3r
Copy link
Member

dav3r commented Aug 3, 2021

For what it's worth, I'm fully on board with dropping S/390 here and opening an issue to put it back later (if/when it works) if we really feel the need to do so.

@felddy
Copy link
Member

felddy commented Aug 5, 2021

@jsf9k Sorry for neglecting this PR.

I think you've got the correct approach figured out. Drop S/390x for now and add it back in if it returns / we need it.

Issue #69 has been created to remind us to
re-add it once it is again supported by the official Python Docker
image.
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specific base images are better.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍

@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Aug 5, 2021
@felddy
Copy link
Member

felddy commented Aug 11, 2021

@felddy, do we really care about supporting the discontinued-for-the-past-20+-years System/390 architecture? I'm inclined to dump support for now and add an issue to remind us to reintegrate it if it returns.

We have learned that s390x is alive and well. See: https://en.wikipedia.org/wiki/Linux_on_IBM_Z

Historically the Linux kernel architecture designations were "s390" and "s390x" to distinguish between the 31-bit and 64-bit Linux on Z kernels respectively, but "s390" now also refers generally to the one Linux on Z kernel architecture.

These machines are still being produced today and should be supported. We need to think of the children. They should have the opportunity to Hack the Gibson.

@mcdonnnj
Copy link
Member

@felddy, do we really care about supporting the discontinued-for-the-past-20+-years System/390 architecture? I'm inclined to dump support for now and add an issue to remind us to reintegrate it if it returns.

We have learned that s390x is alive and well. See: https://en.wikipedia.org/wiki/Linux_on_IBM_Z

Historically the Linux kernel architecture designations were "s390" and "s390x" to distinguish between the 31-bit and 64-bit Linux on Z kernels respectively, but "s390" now also refers generally to the one Linux on Z kernel architecture.

These machines are still being produced today and should be supported. We need to think of the children. They should have the opportunity to Hack the Gibson.

That's fair, but sadly you will need to go upstream to the Python Docker image maintainers to get them to figure out how to generate a functional s390x image 😛

This reverts commit 3ebf37d.

There was finally a successful build of the official Python Docker
image upstream, so we can add this back in.

Resolves #69.
@jsf9k jsf9k linked an issue Aug 23, 2021 that may be closed by this pull request
@jsf9k
Copy link
Member

jsf9k commented Aug 23, 2021

Great news! There was finally a clean build of the official Python Docker image for the s390x architecture, so we can add that back in.

@mcdonnnj mcdonnnj merged commit f446490 into develop Aug 27, 2021
@mcdonnnj mcdonnnj deleted the dependabot/docker/python-3.9.6-alpine branch August 27, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
Development

Successfully merging this pull request may close these issues.

Re-add support for the System/390 architecture when possible
4 participants