Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the ansible version pin #372

Closed
wants to merge 1 commit into from
Closed

Update the ansible version pin #372

wants to merge 1 commit into from

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This updates the ansible version pin used in our Packer projects to match the one used in our Ansible role projects.

💭 Motivation and context

Since our Packer projects consume our Ansible role projects it makes sense to keep these dependencies in sync.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj
Update the Ansible pin
945eb8d 
This updates the Ansible pin used in our Packer projects to match the
version pin used in our Ansible role projects.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use dependencies Pull requests that update a dependency file labels Aug 14, 2024
@mcdonnnj mcdonnnj self-assigned this Aug 14, 2024
@mcdonnnj mcdonnnj requested a review from a team August 14, 2024 08:43
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Aug 14, 2024
@jsf9k jsf9k added this pull request to the merge queue Dec 9, 2024
@mcdonnnj
Copy link
Member Author

mcdonnnj commented Dec 9, 2024

@jsf9k If this PR is problematic just close it as superseded by #376.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 9, 2024
@jsf9k jsf9k added this pull request to the merge queue Dec 9, 2024
@jsf9k jsf9k removed this pull request from the merge queue due to a manual request Dec 9, 2024
@jsf9k
Copy link
Member

jsf9k commented Dec 9, 2024

Superseded by #376.

@jsf9k jsf9k closed this Dec 9, 2024
@jsf9k jsf9k deleted the improvement/update_ansible_pin branch December 9, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @jsf9k @dav3r @dv4harr10