Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: updated examples folder structure #37

Merged
merged 1 commit into from
Jul 22, 2024
Merged

refactor: updated examples folder structure #37

merged 1 commit into from
Jul 22, 2024

Conversation

raresgaia123
Copy link
Contributor

created folders for each example
necessary for documenting each example

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@raresgaia123 raresgaia123 marked this pull request as draft July 18, 2024 07:27
@raresgaia123
Copy link
Contributor Author

Converted to draft untill: #36 is merged.

myungjin
myungjin reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

examples/all_reduce/multiworld_all_reduce.py Outdated Show resolved Hide resolved
examples/resnet/resnet_multiworld.py Outdated Show resolved Hide resolved
examples/send_recv/m8d_asyncio.py Outdated Show resolved Hide resolved
examples/single_world/single_world.py Outdated Show resolved Hide resolved
@myungjin myungjin marked this pull request as ready for review July 19, 2024 16:46
@raresgaia123 raresgaia123 requested a review from myungjin July 22, 2024 08:52
myungjin
myungjin reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/all_reduce/m8d.py Outdated Show resolved Hide resolved
examples/resnet/m8d.py Outdated Show resolved Hide resolved
examples/resnet/m8d.py Outdated Show resolved Hide resolved
examples/send_recv/m8d.py Outdated Show resolved Hide resolved
refactor: updated examples folder structure
1fac22f 
created folders for each example
necessary for documenting each example
myungjin
myungjin approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@myungjin myungjin merged commit f5faf31 into cisco-open:main Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjin myungjin myungjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raresgaia123 @myungjin