-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: examples error handling #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed until all_gather, all_reduce, and broadcast and left comments. Those comments apply to the remaining operations - gather, reduce and scatter. please consider to address them.
This PR is not a feature. This PR is mostly refactoring. So, please update the commit title in git. |
ebf52e0
to
828f13b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments left.
added error handling for examples updated ccl operaions with rank 0 as the actor updated logs for a better understanding of the operations
828f13b
to
f825387
Compare
added error handling for examples
updated ccl operaions with rank 0 as the actor
updated logs for a better understanding of the operations
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist