Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: boolean function to check if world is broken #66

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

myungjin
Copy link
Contributor

@myungjin myungjin commented Aug 5, 2024

Description

A broken world exception is raised for collective operations such as send and recv. However, if those operations are not called and runtime error is not raised, the broken world won't be noticed until any of the operations is called. To check if the world is broken or not without calling the operations, a new function is introduced.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

A broken world exception is raised for collective operations such as
send and recv. However, if those operations are not called and
runtime error is not raised, the broken world won't be noticed until
any of the operations is called. To check if the world is broken or not
without calling the operations, a new function is introduced.
@myungjin myungjin merged commit a8a8573 into cisco-open:main Aug 5, 2024
1 check passed
@myungjin myungjin deleted the new_api branch August 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant