Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap URLs #201

Open
rmzelle opened this issue Jan 22, 2017 · 3 comments
Open

Wrap URLs #201

rmzelle opened this issue Jan 22, 2017 · 3 comments

Comments

@rmzelle
Copy link
Member

rmzelle commented Jan 22, 2017

Currently, long URLs in item metadata don't wrap, creating a horizontal scrollbar in the fixed-width left panel. Apart from making the panel wider, it looks like we could also wrap the URLs with word-wrap:break-word; (per http://stackoverflow.com/a/7309193/1712389).

image

@rmzelle
Copy link
Member Author

rmzelle commented Jan 27, 2017

Digging into this a bit more: apparently Firefox and Chrome wrap URLs different. Chrome doesn't do any wrapping by default, while Firefox wraps at slashes (see mozilla/chronicle#238). The latter still gives problems for the Campbell & Pedersen example on my 13" laptop screen because in this particular case the proxy makes the subdomain + domain part very long ("cps.sagepub.com.turing.library.northwestern.edu"). So it would already help to just change http://cps.sagepub.com.turing.library.northwestern.edu/content/40/3/307.abstract to http://journals.sagepub.com/doi/abs/10.1177/0010414006286542.

word-wrap:break-word; is also still an option.

@adam3smith
Copy link
Member

which it should be anyway, so that's an easy fix.

rmzelle added a commit that referenced this issue Jan 28, 2017
Get rid of proxied URL. Also helps with wrapping, at least in Firefox.
Per #201
@rmzelle
Copy link
Member Author

rmzelle commented Jul 5, 2017

(@zuphilip proposed to use word-break: break-all; at #206 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants