Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL of Campbell & Pedersen article #206

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Conversation

rmzelle
Copy link
Member

@rmzelle rmzelle commented Jan 28, 2017

Get rid of proxied URL. Also helps with wrapping, at least in Firefox.
Per #201

Get rid of proxied URL. Also helps with wrapping, at least in Firefox.
Per #201
@rmzelle
Copy link
Member Author

rmzelle commented Jan 28, 2017

@adam3smith, you can close #206 when you merge this. (I also played around a little with the CSS, but didn't get anywhere)

@adam3smith
Copy link
Member

Someone pointed out to me that most of the other articles with a URL don't have an accessed date -- do you think it's worth adding that?

@rmzelle
Copy link
Member Author

rmzelle commented Jan 28, 2017

I would try to follow what's standard for most Zotero translators. If Zotero usually stores one, I agree we should add them to the metadata here.

@zuphilip
Copy link
Member

I also played around a little with the CSS, but didn't get anywhere

You can try to add to just the url value element this CSS

word-break: break-all;

(This seems to work for me in FF and Chrome.)

@rmzelle
Copy link
Member Author

rmzelle commented Jul 3, 2017

@adam3smith, bump. The accessed date and wrapping issues are unrelated. No reason to not merge this in the meantime.

@adam3smith adam3smith merged commit 1319eea into master Jul 3, 2017
@rmzelle rmzelle mentioned this pull request Jul 5, 2017
@rmzelle rmzelle deleted the update-article-url branch July 5, 2017 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants