Test interaction with both toast compression types in columnar_insert #7670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7670 +/- ##
==========================================
- Coverage 89.69% 81.42% -8.28%
==========================================
Files 283 283
Lines 60510 60287 -223
Branches 7541 7482 -59
==========================================
- Hits 54277 49088 -5189
- Misses 4077 8440 +4363
- Partials 2156 2759 +603 |
Green-Chan
force-pushed
the
extend-columar_insert-test
branch
2 times, most recently
from
1d668e8
to
a78cea1
Compare
Green-Chan
force-pushed
the
extend-columar_insert-test
branch
from
a78cea1
to
6872687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a part of columnar_insert test that tests population of columnar table with data from a table containing toasted values, and only default compression type (i.e. pglz) is checked there. This commit modifies columnar_insert test to check both pglz and lz4.