Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds update_package_properties and build_packages in pg-auto-failover-enterprise #713

Merged
merged 11 commits into from
Sep 1, 2021

Conversation

gurkanindibay
Copy link
Contributor

pipelines

@hanefi
Copy link
Member

hanefi commented Aug 21, 2021

Should be blocked until #709 gots merged. After that one is complete, you can update this PR.

Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After addressing my comments, please compare Github Workflow definitions in all-pgautofailover branch with the ones in here.

.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/update_package_properties.yml Outdated Show resolved Hide resolved
.github/workflows/update_package_properties.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/update_package_properties.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
.github/workflows/build-package.yml Show resolved Hide resolved
.github/workflows/build-package.yml Outdated Show resolved Hide resolved
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove ubuntu/xenial from travis tests as well

run: sudo apt-get update && sudo apt install libcurl4-openssl-dev libssl-dev

- name: Install python requirements
run: sudo apt-get update && python -m pip install -r tools/packaging_automation/requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: sudo apt-get update && python -m pip install -r tools/packaging_automation/requirements.txt
run: python -m pip install -r tools/packaging_automation/requirements.txt

no need to do this again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@gurkanindibay gurkanindibay merged commit 11c5555 into all-pgautofailover-enterprise Sep 1, 2021
@gurkanindibay gurkanindibay deleted the issue_711 branch September 1, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants