-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chauffeur Quiz to MSP #168
base: master
Are you sure you want to change the base?
Conversation
@patrickm02L I'm reviewing this PR and feeling hesitant about how much code was used to create this quiz. I think we need to have a formal technical review of the app before this PR can get approved. Please include all Apps team members. @chiaberry, would you want anyone from your team to be present for this meeting? I know @johnclary already commented about us needing to take a different approach re: authenticating requests in Knack custom code. Please work with @KaroEngstrom to put something on the calendar |
- Replace all direct $.ajax calls with Knack.api methods in quiz functionality - Remove custom headers configuration as they're handled by Knack.api - Maintain existing functionality while using official Knack API methods - Fix 403 and CORS errors in quiz data fetching This change addresses security updates in Knack's API that now require using their official API methods instead of direct AJAX calls.
Hey everyone, I'm going suspend review for now. There was a major refactor that needed to occur to hide the API key, and has now resulted in some new issues. @johnclary I rotated the key and it is now set to a key value. Shout out to @ChrispinP for helping me to use best practice to obscure the API secret. |
@dianamartin is the formal technical review you are describing of the entire app or just for the quiz? In either case, you can include me in the eventual meeting invite |
Description
This PR implements a comprehensive quiz system for chauffeur permit testing, featuring a 25-question randomized assessment with strict attempt controls (3 attempts max, 24-hour cooling period) and UTC-6 time handling. The system requires user authentication to track individual progress and provides admin oversight of all quiz attempts and scores, while ensuring consistent timezone handling across all users.
Closes #18570
Success Criteria
Testing Environment
Knack Test Environment Access
Testing Steps
1. Quiz Taking Flow
2. Quiz Results Verification
3. Testing 24-Hour Wait Period
4. Testing Multiple Attempts
5. Testing Maximum Attempts Message