render link to cabinet details as menu button #78
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,12 +11,18 @@ function customizeLoginButton(viewId) { | |
|
|
||
| // Create a div for Login buttons | ||
| var $coacdButton = $("<div/>", { | ||
| id: "coacd-button-login", | ||
| }); | ||
| $coacdButton.appendTo("#" + viewId); | ||
|
|
||
| // Append Big SSO Login button and non-SSO Login button | ||
| bigButton( | ||
| "coacd-big-button", | ||
| "coacd-button-login", | ||
| url, | ||
| "sign-in", | ||
| "Sign-In" | ||
| ); | ||
|
|
||
| $coacdButton.append( | ||
| "<a class='small-button' href='javascript:void(0)'>" + | ||
|
|
@@ -53,10 +59,29 @@ $(document).on("knack-view-render.any", function (event, page) { | |
| /*************** Big Buttons ****************/ | ||
| /********************************************/ | ||
| //Create Big Button nested in a block | ||
| function bigButton( | ||
| id, | ||
| view_id, | ||
| url, | ||
| fa_icon, | ||
| button_label, | ||
| is_disabled = false, | ||
| callback = null | ||
| ) { | ||
| var disabledClass = is_disabled ? " big-button-disabled'" : "'"; | ||
| $( | ||
| "<a id='" + | ||
| id + | ||
| "' class='big-button-container" + | ||
| disabledClass + | ||
| " href='" + | ||
| url + | ||
| "'><span><i class='fa fa-" + | ||
| fa_icon + | ||
| "'></i></span><span> " + | ||
| button_label + | ||
| "</span></a>" | ||
| ).appendTo("#" + view_id); | ||
|
|
||
| if (callback) callback(); | ||
| } | ||
|
|
@@ -65,10 +90,29 @@ function bigButton(id, view_id, url, fa_icon, button_label, is_disabled = false, | |
| /************** Small Buttons ***************/ | ||
| /********************************************/ | ||
| //Create Small Button nested in a block | ||
| function smallButton( | ||
| id, | ||
| view_id, | ||
| url, | ||
| fa_icon, | ||
| button_label, | ||
| is_disabled = false, | ||
| callback = null | ||
| ) { | ||
| var disabledClass = is_disabled ? " small-button-disabled'" : "'"; | ||
| $( | ||
| "<a id='" + | ||
| id + | ||
| "' class='back-button" + | ||
| disabledClass + | ||
| " href='" + | ||
| url + | ||
| "'><span><i class='fa fa-" + | ||
| fa_icon + | ||
| "'></i></span><span> " + | ||
| button_label + | ||
| "</span></a>" | ||
| ).appendTo("#" + view_id); | ||
|
|
||
| if (callback) callback(); | ||
| } | ||
|
|
@@ -568,7 +612,10 @@ $(document).on("knack-scene-render.scene_1171", function (event, page) { | |
| $("#" + detailsView) | ||
| .find("div.kn-detail." + fields.quantity.current) | ||
| .find(".kn-detail-body span")[0] | ||
| ) | ||
| .text() | ||
| .replaceAll(",", "") | ||
| .trim() | ||
| ); | ||
|
|
||
| // handle situation where stock levels are negative (this should not but prob will happen) | ||
|
|
@@ -746,7 +793,6 @@ $(document).on("knack-scene-render.scene_634", function (event, scene) { | |
| /// Begin Technician Time Log Validation /// | ||
| //////////////////////////////////////////// | ||
|
|
||
| function appendErrorMessage(viewKey, formDiv, msg) { | ||
| // remove existing error msg if present | ||
| var errorDiv = $( | ||
|
|
@@ -852,19 +898,12 @@ $(document).on("knack-view-render.view_1252", function (event, page) { | |
| highlightErrorField(`#${viewKey}-${startField.key}`); | ||
| highlightErrorField(`#${viewKey}-${endField.key}`); | ||
|
|
||
| errorMsgs = `${errorMsgs}${formatErrorMessage(startField, endField)}`; | ||
|
|
||
| } | ||
| } | ||
| if (!passesValidation) { | ||
| // show red error banner | ||
|
|
||
| appendErrorMessage(viewKey, formDiv, errorMsgs); | ||
| } | ||
| return passesValidation; | ||
| }); | ||
|
|
@@ -873,3 +912,16 @@ $(document).on("knack-view-render.view_1252", function (event, page) { | |
| //////////////////////////////////////////// | ||
| /// End Technician Time Log Validation /// | ||
| //////////////////////////////////////////// | ||
|
|
||
| //// Update link text to cabinet details page from signal detals | ||
|
There was a problem hiding this comment. Instead of JS, use this Trigger Button article styling the button with CSS and calling it with the HTML whenever you need it. There was a problem hiding this comment. ah, that's a cool trick! TIL. those docs are excellent! in this case i'm styling a details link from a connection field, so i don't have control in the builder over what html is rendered by Knack. without this custom code, the link text would simply be the display field on the cabinets record. for the CSS, i'm just using the same classes that knack uses on their menu buttons. that actually might be a nice improvement in your docs. you might not need to write any custom CSS if you can get by with the knack classes. |
||
| $(document).on("knack-view-render.view_1261", function (event, page) { | ||
| // find cabinet ID field div | ||
| var el = $(".field_1789"); | ||
| // find child <a> | ||
| var a = $(el).find("a"); | ||
| // update text | ||
| $(a).addClass("kn-link kn-link-1 kn-link-page kn-button"); | ||
| $(a).html( | ||
| "<span class='icon is-small'><i class='fa fa-list'></i></span><span>Cabinet details</span>" | ||
| ); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious on the reasoning of re-expanding the SSO code to take up more lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default formatting behavior of Prettier. i actually was surprised it picked up more linting, since i linted this code the last time i edited it a few months ago. it makes me wonder if knack does some kind of linting automatically, or if my linter settings changed somehow.
i'm happy to defer to the linter's opinions, which aim for more readable code over being concise. in the past we've talked about standardizing these settings and making sure we use them globally, basically the standard right now it prettier's default.