Forbid class props in react
#24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, we've had a custom overcommit hook protecting against using `class` instead of `className` as a prop. For React newcomers, this is a common mistake to make, so it's good to have some protection in place. Instead of the custom overcommit hook, we can instead just prevent this through the react/forbid-component-props rule [1]. [1] https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-component-props.md
MatthewHerbst
approved these changes
May 19, 2017
There was a problem hiding this comment.
LGTM, but the react/no-unknown-property rule should in theory be covering this use case already
|
Awesome, thanks for pointing that out. For some reason, that isn't catching things for me. We'll have to investigate before deciding whether to merge this or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we've had a custom overcommit hook protecting against using
classinstead ofclassNameas a prop. For React newcomers, this is acommon mistake to make, so it's good to have some protection in place.
Instead of the custom overcommit hook, we can instead just prevent this
through the react/forbid-component-props rule [1].
[1] https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-component-props.md