Optimize Change Log Viewing For A Contact #31125
Open
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
shahrukh-compuco
pushed a commit
to compucorp/civicrm-core
that referenced
this pull request
Sep 17, 2024
shahrukh-compuco
pushed a commit
to compucorp/civicrm-core
that referenced
this pull request
Sep 17, 2024
shahrukh-compuco
pushed a commit
to compucorp/civicrm-core
that referenced
this pull request
Sep 17, 2024
shahrukh-compuco
pushed a commit
to compucorp/civicrm-core
that referenced
this pull request
Sep 17, 2024
| $logEntries[] = [ | ||
| 'id' => $log->modified_id, | ||
| 'name' => $displayName, | ||
| 'image' => $contactImage, | ||
| 'name' => $log->modified_id && $modifiers[$log->modified_id]['name'] ? $modifiers[$log->modified_id]['name'] : '', |
There was a problem hiding this comment.
I think this should be better done as $modifiers[$log->modified_id]['name'] ?? '' right @eileenmcnaughton ?
There was a problem hiding this comment.
I agree. @shahrukh-compuco can you make that change please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr optimizes the code for viewing the change logs for a contact.
Technical Details
Currently during fetching the change log for a contact we also fetch information for modifier contact here once for each row from the log table. This can give timeout errors on big databases as each call to the function getDisplayAndImage results in one query being executed. Even if same modifier changed the one contact multiple times we will have multiple queries for fetching same information for same modifier.
This pr changes the code to store the modifier information in an array and only query the modifier info if its not already available in the array thus results in significantly lesser number of queries for large change logs.