Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(REF) MockPublicFormTest - Small cleanups/fixups #31147

Closed
wants to merge 4 commits into from
Closed

(REF) MockPublicFormTest - Small cleanups/fixups #31147

wants to merge 4 commits into from

Conversation

totten
Copy link
Member

@totten totten commented Sep 20, 2024 •
edited
Loading

Overview

This is extracted from #30585. It includes some of the smaller cleanups from the start. (This should make the main PR smaller.)

@totten
GuzzleMiddleware::curlLog() - Compatibility with Guzzle 7
48ebd1c 
This only runs when you enable debugging for e2e tests (DEBUG=1).
@totten
(REF) MockPublicFormTest - Extract method assertUrlStartsSession()
1e6c79e
@totten
(REF) MockPublicFormTest - Shorter assertion
12c0bed
@totten
(REF) MockPublicFormTest - Reorganize/simplify tests
39d1d5a 
Before: Separate tests for different permutations of token-name/output-media

After: One test checks consistency across token-names/output-media -- asserting
       that they all point to the same URL.

       Another test checks whether that URL behaves corectly.
@civibot civibot
Copy link

civibot bot commented Sep 20, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Sep 20, 2024
@totten totten closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@totten