-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone login improvements (message/theme/events) #31149
base: master
Are you sure you want to change the base?
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
732873f
to
532cebf
Compare
Good r-ran on the test site and all works as expected for me. Code looks fine to me. Blocking Couple of test fails were the test is looking for specific wording so need updating with the notification copy changes (The upgrade test is new and the fail is not this PRs fault) Non-blocking I think I liked the login box lower down for some reason but 🤷♂️ Also noticed on stock Greenwich the inputs don't align so nice This wasn't a problem before because they were underneath If the html makes sense and is themeable then I can live with it. @vingle ? |
re wide inputs - yeah, I know, I liked them big too and I was trying to make them "huge" and testing with riverlea but couldn't get them to behave. I thought it was likely a RL bug, but maybe not. EDIT: I've added more CSS to override greenwich and make those block layout again, so they now look like your 2nd screenshot again. will check tests. thanks @ufundo |
99a73d5
to
24896eb
Compare
|
@vingle thanks, I've removed huge. (I had thought it was a new RL thing, and on my thames theme I'd set it to 100%... didn't realise it was an old rule.) |
@artfulrobot - I hadn't initially included it, but then noticed some inputs on the add new contact page were larger than others. Probably more elegant ways to do that than |
This gives other extensions opportunity to implement various extra login guards, e.g. excessive wrong passwords/mfa attempts. standalone: Login/TOTP improve notifications using status messages standalone: minor css improvement for login standalone: shrink QR code a bit, it was mahusive standalone: remove API_Exception → CRM_Core_Exception fix style Update tests for changed wording in standalone standalone: remove huge - we want it *bigger*! style fix
87c5e47
to
a70decb
Compare
Various standalone login related items: