Standalone System - use authx_login for authenticate flow #31153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use the
authx_login
flow inCRM_Utils_System_Standalone::authenticate
- so we have a common codepath for all logins.Before
After
Technical Details
@totten noted this will mean the login is subject to AuthX policies. The pertinent one is if
password
isn't enabled as a credential type, then it will not be accepted. However you also wouldn't be able to log in to your Standalone site through the web UI - so seems an unlikely edge case.I'm not totally sure what flows through this function. @totten mentioned
cron.php
- though that is deprecated and won't work on Standalone for other reasons.