Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone System - use authx_login for authenticate flow #31153

Merged

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Sep 20, 2024

Overview

Use the authx_login flow in CRM_Utils_System_Standalone::authenticate - so we have a common codepath for all logins.

Before

  • a bespoke implementation of the login flow here

After

  • use the canonical one from authx extension

Technical Details

@totten noted this will mean the login is subject to AuthX policies. The pertinent one is if password isn't enabled as a credential type, then it will not be accepted. However you also wouldn't be able to log in to your Standalone site through the web UI - so seems an unlikely edge case.

I'm not totally sure what flows through this function. @totten mentioned cron.php - though that is deprecated and won't work on Standalone for other reasons.

Copy link

civibot bot commented Sep 20, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Sep 20, 2024
@ufundo ufundo force-pushed the standalone-system-authenticate-with-authx branch from 96d4c58 to 8c724b0 Compare September 20, 2024 20:26
@ufundo ufundo marked this pull request as ready for review September 20, 2024 20:27
@ufundo ufundo added the run-standalone Civibot should setup demos+tests for Standalone label Oct 4, 2024
@ufundo
Copy link
Contributor Author

ufundo commented Oct 8, 2024

Thanks @colemanw

Upgrade tests are failing on master

@colemanw colemanw merged commit 6f411e1 into civicrm:master Oct 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge on pass run-standalone Civibot should setup demos+tests for Standalone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants