dev/core#5609 - Fix literal <del> appearing on activity tab when source contact is deleted

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/5609

Before

1. Delete a contact that has activities where they are the source contact.
2. Visit their activity tab.
3. It has a literal <del> tag appearing.

Two things going on:

1. Inserting <del> into the field's text value isn't really the right way to style.
2. There's double-escaping of the actual value because it's escaped here and then later at

   civicrm-core/CRM/Activity/BAO/Activity.php

   Line 2347 in 9a3717d

   $activity['source_contact_name'] = htmlentities($values['source_contact_name']);

   . For example if the contact name is "O'Reilly & Sons". This is sort of separate from the <del> problem, but the double-escaping only happens when the contact is deleted.

After

No styling, but it's a datatable so I'm not sure how to properly style it. It's nice to have, but this also solves the double-escaping.

Technical Details

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5609