-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#392] Inline CSS dependencies. #402
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 13.87% 13.87%
=======================================
Files 27 27
Lines 1290 1290
Branches 307 307
=======================================
Hits 179 179
Misses 894 894
Partials 217 217 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alan-cole this is awesome - two depedencies removed.
#392
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.
Changed
section about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
box-sizing: border-box;
) into components. A component should not rely on styles applied outside the scope of the component. This could lead to conflicts if used alongside other component systems, and also makes packaging discreet component styles difficult.Known issues:
html
, andbody
) that will be moved into the Drupal theme, as they aren't related to a component that exists within civictheme. PR here: [CIVIC-1937] Add page level styles into Drupal theme. monorepo-drupal#1308 and should be merged before the UI Kit changes are merged.Screenshots