-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality of life improvements #195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Performance Improvement: Skip rows when showing datastore load when handing multi million line records * Improve testing on mixed formatting where type loading causes bad loads when it has a empty field on type timestamp/numeric, 'can't be string' must be none * Include shortcut to datastore when loaded for Package/Resource maintainers+ * Include dependabot pr auto raising to help keep current * Make flake8 more stringent
* [QOLDEV-347] apply 'str' fallback type correctly * [QOLDEV-347] fix validation errors on empty strings * [QOLDEV-424] set default CSV sample size in config to match previous product 1000 lines * [QOLDEV-424] handle parsing CSV file with commas inside quotes better
…fidence Also have fallback to windows encoding if all else fails
- Windows-1252 is a superset, which makes it more useful for this purpose
Hi @kowh-ai , @smotornyuk Regards, |
ThrawnCA
approved these changes
Jan 29, 2024
… upstream_updates
… upstream_updates
- Recognise 0 as a valid numeric value - Fix whitespace and unused import - Extract maximum retry count to a constant - Use context managers to automatically close streams - Add README note about configuring PostgreSQL date style - Add titles to queued jobs so they are more easily administered
ThrawnCA
force-pushed
the
upstream_updates
branch
from
February 2, 2024 04:46
f9ae259
to
6eb5658
Compare
ThrawnCA
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecated config option ckanext.xloader.just_load_with_messytables
Fallback to ISO_8859 which covers majority of Windows-1252
So we try to convert cells to numbers or timestamps if applicable:
If a list of types was supplied, use that.
If not, then try converting each column to numeric first, then to a timestamp.
If both fail, just keep it as a string.
when auth allows (Resource uploader and above)
Only show the start and end (default first 50 and last 50) with ability to request more rows or all rows if so desired.
As well as lots of extra tests for edge conditions