Delete Datastore Table Button #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added view to delete datastore table. - Added button to delete a resource's datastore table.
- Added csrf field to delete button form.
ThrawnCA
reviewed
Nov 8, 2023
- Removed the word `table` from user visible things.
- Used `get_action` from toolkit instead of ckanapi dependency.
|
@ThrawnCA for this PR, I also reverted the |
ThrawnCA
approved these changes
Nov 9, 2023
|
Looks good from here. |
|
Ideally there should be a sanity check to ensure that the package ID is correct for the resource ID. |
- Confirm that the resource id belongs to the package id.
- Condition delete button behind `datastore_active`. - Fix context variable in view.
ThrawnCA
approved these changes
Nov 17, 2023
ThrawnCA
reviewed
Nov 17, 2023
ThrawnCA
reviewed
Nov 17, 2023
ThrawnCA
requested changes
Nov 17, 2023
ThrawnCA
requested changes
Dec 28, 2023
There was a problem hiding this comment.
After the confirm-action JavaScript runs, the button submits a datastore refresh instead of deletion.
Our fork will fix this with qld-gov-au#74
# Conflicts: # ckanext/xloader/views.py ### RESOLVED.
- Fix layout of delete button with upload button. - Changed delete button icon.
|
@ThrawnCA button alignment should be good now |
ThrawnCA
reviewed
Jan 29, 2024
ThrawnCA
requested changes
Jan 29, 2024
- Move sets into their respective blocks.
ThrawnCA
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(views): added view and button to delete ds table;
Adds a button to the Xloader data page to delete a Resource's datastore table.