Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN 2.11 support #220

Merged
merged 2 commits into from
Jul 17, 2024
Merged

CKAN 2.11 support #220

merged 2 commits into from
Jul 17, 2024

Conversation

amercader
Copy link
Member

No description provided.

@amercader
Copy link
Member Author

The failure on 2.11 looks interesting. Seems like there is an issue with the field types being created:

>       assert self._get_column_types(Session, resource_id) == [
            u"int4",                                                 
            u"tsvector",                                             
            u"timestamp",                                            
            u"numeric",                                              
            u"text",                                                 
        ]                                                            
E       AssertionError: assert ['int4', 'tsvector', 'text', 'text', 'text'] == ['int4', 'tsvector', 'timestamp', 'numeric', 'text']
E                                                                    
E         At index 2 diff: 'text' != 'timestamp'
E                                                                    
E         Full diff:                                                 
E           [                                                        
E               'int4',                                              
E               'tsvector',                                          
E         -     'timestamp',                                         
E         -     'numeric',                                           
E         +     'text',                                              
E         +     'text',                                              
E               'text',                                              
E           ]                                                        

ckanext/xloader/tests/test_loader.py:763: AssertionError

@wardi can you think of a change in the datastore since 2.10 that might cause this? Perhaps the field info stuff related to Table Designer?

@wardi
Copy link
Contributor

wardi commented Jul 9, 2024

Interesting, maybe IDataDictionaryForm-related if xloader can't find its type overrides. I'll take a look

@amercader amercader marked this pull request as ready for review July 17, 2024 09:50
@amercader amercader merged commit a96ce28 into master Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants