Frontend Status Badges #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added status badges.
ThrawnCA
reviewed
Aug 2, 2024
ckanext/xloader/helpers.py
Outdated
| } | ||
| debug_level_statuses = ['complete', 'active', 'inactive', 'unknown'] | ||
|
|
||
| if status in debug_level_statuses and not toolkit.asbool(toolkit.config.get('ckanext.xloader.debug_badges', False)): |
There was a problem hiding this comment.
I would prefer to reverse this, checking a list of statuses that can be shown regardless, then if the current status isn't on that list, require the debug flag.
There was a problem hiding this comment.
@ThrawnCA okay lemme know if that is better (and if I even did what you actually asked for haha). Thanks!
- Reverse debug badge logic.
ThrawnCA
reviewed
Aug 16, 2024
| except toolkit.ObjectNotFound: | ||
| xloader_job = {} | ||
|
|
||
| if xloader_job.get('status') == 'complete': |
There was a problem hiding this comment.
Could refactor this to extract xloader_job.get('status') to a variable at the start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(templates): status badges;
As promised back in February (here: #200 (comment)), this adds frontend badges stating the status of the xloadering and availability in the datastore.
Threw in the French (at least French Canadian) badges as well.