Converted the ckeditor5-dev-ci package to ESM
#997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomek
reviewed
Sep 4, 2024
pomek
reviewed
Sep 5, 2024
pomek
reviewed
Sep 5, 2024
pomek
reviewed
Sep 5, 2024
pomek
reviewed
Sep 5, 2024
martnpaneq
reviewed
Sep 6, 2024
| import { defineConfig } from 'vitest/config'; | ||
|
|
||
| export default defineConfig( { | ||
| test: { |
There was a problem hiding this comment.
For now this is fine, but if we are going to rewrite other packages, we need to store the config in a common place.
martnpaneq
reviewed
Sep 6, 2024
|
|
||
| describe( 'lib/utils/getJobApprover', () => { | ||
| let stubs, getJobApprover; |
There was a problem hiding this comment.
This looks pretty awesome. I like that in Vitest all of this bloated code is not needed.
pomek
changed the title
ckeditor5-dev-ci package to ESM
pomek
requested changes
Sep 9, 2024
There was a problem hiding this comment.
ESM requires extensions in import/export when operating on local files. You can fix it by updating ESLint rules.
Lines 28 to 33 in 281aaea
pomek
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (ci): Converted the package to ESM.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.