Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CDN integration and shared utils to package #1

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Move CDN integration and shared utils to package #1

merged 5 commits into from
Aug 19, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Aug 13, 2024 •
edited
Loading

Suggested merge commit message (convention)

Feature: Move CDN integration files and utils to commons package.
Feature: Move generic utils from React integration to commons package.

Additional information

Related issue: https://github.com/cksource/ckeditor5-internal/issues/3741
More PRs related to CDN integration:

  1. Cloud integration ckeditor5-react#510
  2. Cloud integration ckeditor5-vue#301
  3. Cloud integration ckeditor5-angular#431

@Mati365 Mati365 force-pushed the ck/cdn-integration branch 2 times, most recently from b983830 to bb14d56 Compare August 14, 2024 09:26
pomek
pomek reviewed Aug 19, 2024
View reviewed changes
scripts/postinstall.js Outdated Show resolved Hide resolved
pomek
pomek reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose minor changes related to CI.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@pomek
Copy link
Member

pomek commented Aug 19, 2024

Please, update the CircleCI badge in README too.

[![CircleCI](https://circleci.com/gh/ckeditor/ckeditor5-integrations-common.svg?style=shield)](https://app.circleci.com/pipelines/github/ckeditor/ckeditor5-integrations-common?branch=master)

pomek
pomek reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned the proposed changes briefly and focused only on released-oriented things. It looks good.

gorzelinski
gorzelinski reviewed Aug 19, 2024
View reviewed changes
Copy link

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests and scripts. I looked through the code and docs. Everything seems to be fine.

package.json Outdated Show resolved Hide resolved
tests/cdn/ck/createCKCdnBaseBundlePack.test.ts Show resolved Hide resolved
README.md Show resolved Hide resolved
filipsobol
filipsobol reviewed Aug 19, 2024
View reviewed changes
src/cdn/ck/createCKCdnBaseBundlePack.ts Outdated Show resolved Hide resolved
src/cdn/ck/createCKCdnPremiumBundlePack.ts Outdated Show resolved Hide resolved
src/utils/defer.ts Show resolved Hide resolved
src/cdn/ck/createCKCdnBaseBundlePack.ts Outdated Show resolved Hide resolved
src/cdn/ck/createCKCdnPremiumBundlePack.ts Outdated Show resolved Hide resolved
src/cdn/loadCKEditorCloud.ts Outdated Show resolved Hide resolved
src/utils/injectScript.ts Outdated Show resolved Hide resolved
src/utils/injectStylesheet.ts Outdated Show resolved Hide resolved
src/utils/preloadResource.ts Outdated Show resolved Hide resolved
tests/utils/preloadResource.test.ts Outdated Show resolved Hide resolved
filipsobol
filipsobol previously approved these changes Aug 19, 2024
View reviewed changes
src/cdn/combineCKCdnBundlesPacks.ts Outdated Show resolved Hide resolved
@Mati365 Mati365 merged commit c7e4470 into master Aug 19, 2024
4 checks passed
@pomek pomek deleted the ck/cdn-integration branch August 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorzelinski gorzelinski gorzelinski left review comments

@pomek pomek pomek left review comments

@filipsobol filipsobol filipsobol approved these changes

@niegowski niegowski Awaiting requested review from niegowski

@arkflpc arkflpc Awaiting requested review from arkflpc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mati365 @pomek @filipsobol @gorzelinski