Replaced Karma with Vitest in generated package #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restored `global document` annotation.
Added description for `--watch` CLI flag.
Limited `vite-plugin-svgo` to version < 1.5.0 that is corrupted right now.
|
Watch mode is now disabled in tests in the generated package. It can be enabled with |
pomek
reviewed
Sep 5, 2024
packages/ckeditor5-package-generator/lib/templates/js/vitest.config.ts.txt
Outdated
Show resolved
Hide resolved
|
PR with updates in the CKEditor 5 docs: ckeditor/ckeditor5#17051 |
martnpaneq
approved these changes
Sep 6, 2024
pomek
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (generator): Replaced Karma with Vitest as the testing framework in the generated package.
Other (tools): Removed support for the
--coverage(-c) and--source-map(-s) flags.Other (tools): Removed
testscript from the tools, because unit tests in the generated package are executed now directly by Vitest.MINOR BREAKING CHANGE (generator): The generated package no longer uses Karma as the test runner. Instead, Vitest is used.
MINOR BREAKING CHANGE (tools): The
testscript is removed, because unit tests in the generated package are executed directly by Vitest. Hence, the previous custom support for the--coverage(-c) and--source-map(-s) flags is no longer needed and has been also removed. Theyarn run test(ornpm run test) script is still available in the generated package, but it executes Vitest. See CLI flags supported in Vitest.Additional information
Closes https://github.com/cksource/ckeditor5-internal/issues/3756.
Supported scopes
generator→ https://www.npmjs.com/package/ckeditor5-package-generator*→ https://www.npmjs.com/package/@ckeditor/ckeditor5-package-*