Support for image height attribute #14763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preserve-image-width-and-height
…preserve-image-width-and-height
…width-and-height-on-upload
…mage-width-and-height Feature (image): It should be possible to load and preserve image width and height attributes. Closes #14201. MAJOR BREAKING CHANGE (image): The name of the image resize width attribute has been changed to resizedWidth. The width and height attributes are now used to preserve image width and height. MAJOR BREAKING CHANGE (image): The srcset attribute has been simplified. It is no longer an object { data: "...", width: "..." }, but a value previously stored in the data part.
…4202-set-image-width-and-height-on-upload
…4202-set-image-width-and-height-on-upload
niegowski
requested changes
Sep 6, 2023
packages/ckeditor5-image/tests/manual/imagesizeattributesallcases.js
Outdated
Show resolved
Hide resolved
…ditional converters.
niegowski
approved these changes
Sep 7, 2023
|
Please ping me or @godai78 when this PR will be merged, we need to check how it works with PfO and PfOE plugins. It will be needed to update comparison table of those plugins 👉 https://github.com/cksource/ckeditor5-commercial/pull/5493#issuecomment-1713988801. |
arkflpc
approved these changes
Sep 14, 2023
|
Let's remember to add these to the Updating guide: #14981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (image): The image
widthandheightattributes are preserved while loading editor content. Closes #14146.Feature (image): Images without size specified will automatically gain natural image size on any interaction with the image. See #14146.
MAJOR BREAKING CHANGE (image): The model attribute name of the resized image is now changed to
resizedWidth. Thewidthandheightattributes are now used to preserve the image's natural width and height.MAJOR BREAKING CHANGE (image): The
srcsetmodel attribute has been simplified. It is no longer an object{ data: "...", width: "..." }, but a value previously stored in thedatapart.Additional information
https://github.com/cksource/ckeditor5-commercial/pull/5505
We had to update image model attribute name from
widthtoresizedWidth.