Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable block drag and drop by default #15016

Merged
merged 13 commits into from
Sep 26, 2023

Conversation

illia-stv
Copy link
Contributor

@illia-stv illia-stv commented Sep 18, 2023

Suggested merge commit message (convention)

Feature (clipboard): Block drag and drop should be enabled by default. Closes #14734.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@@ -10,7 +10,7 @@
import { Plugin } from '@ckeditor/ckeditor5-core';

import ClipboardPipeline from './clipboardpipeline';
import DragDrop from './dragdrop';
import DragDropExperimental from './dragdropexperimental';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DragDropExperimental should replace old DragDrop plugin.

@illia-stv
Copy link
Contributor Author

illia-stv commented Sep 19, 2023

Diffs could looks terrifying, especially in dragdrop.ts file, but there is only renaming from dragdropexperimental with dragdrop. Same with dragdrop.js in tests.

Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing code coverage.

@niegowski niegowski merged commit a9eff48 into master Sep 26, 2023
@niegowski niegowski deleted the ck/14734-enable-block-drag-and-drop-by-default branch September 26, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drag & drop] Enable block drag and drop by default
3 participants