New linking experience. #17368
Draft
New linking experience. #17368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input, as it won't have any validation
Co-authored-by: Kuba Niegowski <[email protected]> Co-authored-by: Piotr Szczęśniak <[email protected]>
…230-link-toolbar # Conflicts: # packages/ckeditor5-link/src/linkui.ts
Feature (link): Add the Bookmarks panel to the link UI. See #17230.
Other (link): Rename the `cancel` event to `back` in `LinkAdvancedView`. See #17230.
Other (link): The Link feature now uses the ToolbarView instead of a custom LinkActionsView to display the link toolbar in the contextual balloon. The new toolbar uses components registered in the ComponentFactory. Other (bookmark): The Bookmark feature now uses the WidgetToolbarRepository instead of a custom ActionsView to display the bookmark toolbar in the contextual balloon. The new toolbar uses components registered in the ComponentFactory. Fix (ui): The ButtonView#icon property can now be set/reset after the button's first render. Other (ui): The IconView now throws a meaningful error if the provided icon content is not a valid SVG. Other (widget): The WidgetToolbarRepository#register() now accepts a customized list of desired balloon positions. BREAKING CHANGE (link): The LinkUI#actionsView is no longer available. The bookmark feature now uses the LinkUI#toolbarView (an instance of the ToolbarView class) instead of the custom LinkActionsView. BREAKING CHANGE (bookmark): The BookmarkUI#actionsView is no longer available. The Bookmark feature is now using the WidgetToolbarRepository instead. MINOR BREAKING CHANGE (link): The createBookmarkCallbacks() helper is now replaced by the isScrollableToTarget() and scrollToTarget() helpers.
pszczesniak
commented
Nov 15, 2024
| margin: 0; | ||
|
|
||
| @mixin ck-media-phone { | ||
| margin: var(--ck-spacing-large) var(--ck-spacing-medium) var(--ck-spacing-medium) var(--ck-spacing-medium); |
There was a problem hiding this comment.
Suggested change
| margin: var(--ck-spacing-large) var(--ck-spacing-medium) var(--ck-spacing-medium) var(--ck-spacing-medium); | |
| margin: var(--ck-spacing-large) var(--ck-spacing-medium) var(--ck-spacing-medium) var(--ck-spacing-medium); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Type: !!TODO!! describe changes in the link form. Closes #000.
Other (link): The Link feature now uses the
ToolbarViewinstead of a customLinkActionsViewto display the link toolbar in the contextual balloon. The new toolbar uses components registered in theComponentFactory.Other (bookmark): The Bookmark feature now uses the
WidgetToolbarRepositoryinstead of a customActionsViewto display the bookmark toolbar in the contextual balloon. The new toolbar uses components registered in theComponentFactory.Fix (ui): The
ButtonView#iconproperty can now be set/reset after the button's first render.Other (ui): The
IconViewnow throws a meaningful error if the provided icon content is not a valid SVG.Other (widget): The
WidgetToolbarRepository#register()now accepts a customized list of desired balloon positions.BREAKING CHANGE (link): The
LinkUI#actionsViewis no longer available. The bookmark feature now uses theLinkUI#toolbarView(an instance of theToolbarViewclass) instead of the customLinkActionsView.BREAKING CHANGE (bookmark): The
BookmarkUI#actionsViewis no longer available. The Bookmark feature is now using theWidgetToolbarRepositoryinstead.MINOR BREAKING CHANGE (link): The
createBookmarkCallbacks()helper is now replaced by theisScrollableToTarget()andscrollToTarget()helpers.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.