No longer abort already destroyed FileLoader
in FileRepository
.
#17475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (upload): Editor should no longer crash when executing undo while an image is still being uploaded.
Additional information
Closes https://github.com/cksource/ckeditor5-commercial/issues/6817
It looks like
undo
moves uploaded node to graveyard, which causes abort image uploading here:https://github.com/ckeditor/ckeditor5/blob/ck/6817/packages/ckeditor5-image/src/imageupload/imageuploadediting.ts#L227
which causes
aborted
exception, that is caught here:https://github.com/ckeditor/ckeditor5/blob/ck/6817/packages/ckeditor5-image/src/imageupload/imageuploadediting.ts#L387-L389
... and tries to abort again, which causes exception. I adjusted
FileLoader
method to handle similar scenarios, and asseration in image upload.