This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
WIP: Remove jenkins requirement #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spbnick
force-pushed
the
remove_jenkins_requirement
branch
2 times, most recently
from
641a546
to
2e481e5
Compare
Move sktm.tresult to sktm.misc.tresult to fix composition, so that modules lower in the hierarchy (e.g. sktm.jenkins) do not have to import the module above (i.e. sktm). Fixes cki-project#6
Instead of creating and using a "Jenkins Interface"
(sktm.jenkins.skt_jenkins), and then supplying a project name
("jobname") with every method call, create and use a "Jenkins Project
Interface" (sktm.jenkins.Project) and only supply the project name on
its creation.
This simplifes the interface, and removes a bit of code.
This also prepares for abstracting Jenkins away.
Mark sktm.jenkins.Project private methods by prepending them with double underscore. Concerns cki-project#12
spbnick
force-pushed
the
remove_jenkins_requirement
branch
from
2e481e5
to
f35d989
Compare
Spell out "patch URL list" instead of writing "patchwork" in sktm.jenkins.Project, to make clear what's being accepted/returned. Leave updating the Jenkins project parameter name for later.
Create a complete Jenkins project interface instance and pass it to the watcher, instead of having the watcher create it. This prepares the watcher to using abstract scheduler interface, instead of Jenkins specifically.
spbnick
force-pushed
the
remove_jenkins_requirement
branch
from
f35d989
to
7d1ca5e
Compare
dzickusrh
reviewed
Jun 1, 2018
dzickusrh
reviewed
Jun 1, 2018
dzickusrh
reviewed
Jun 1, 2018
dzickusrh
reviewed
Jun 1, 2018
dzickusrh
reviewed
Jun 1, 2018
dzickusrh
reviewed
Jun 1, 2018
dzickusrh
reviewed
Jun 1, 2018
|
Overall, I personally think the first 7 patches should be merged. It is needed cleanup anyway and might be blocking other changes. The scheduler piece is going to take time to flush out and shouldn't block the first 7 patches. |
|
Thanks for the review, Don! Yeah, I have the refactoring part in #52, ready for review :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work-in-progress of removing the requirement to have Jenkins setup and configured to run sktm.
This is not tested and likely breaks stuff at this moment.