feat: add additional log levels #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 11865462674Details
💛 - Coveralls |
epage
reviewed
Nov 13, 2024
epage
reviewed
Nov 13, 2024
epage
reviewed
Nov 13, 2024
joshka
commented
Nov 14, 2024
joshka
force-pushed
the
jm/additional-log-levels
branch
2 times, most recently
from
31517ef to
7f9b94c
Compare
epage
reviewed
Nov 14, 2024
This adds `OffLevel`, `DebugLevel`, and `TraceLevel` to the list of log levels that can be set as the default log level for the logger. Fixes: clap-rs#122
This commit removes the unnecessary `allow(clippy::exhaustive_structs)` directives from the `ErrorLevel`, `WarnLevel`, and `InfoLevel` structs as these are not triggered by the current clippy configuration.
A new example, `log_level.rs`, demonstrates how to set the default log level for Verbosity to something other than the default. It can be run with `cargo run --example=log_level [default level] [flags]`. E.g.,: `cargo run --example=log_level off -vvvv` will set the default log level to `OffLevel` and then apply the verbosity flags to set the log level to `Debug`.
joshka
force-pushed
the
jm/additional-log-levels
branch
from
7f9b94c to
2192330
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
OffLevel,DebugLevel, andTraceLevelto the list of loglevels that can be set as the default log level for the logger.
A new example,
log_level.rs, demonstrates how to set the default loglevel for Verbosity to something other than the default. It can be run
with
cargo run --example=log_level [default level] [flags]. E.g.,:cargo run --example=log_level off -vvvvwill set the default log levelto
OffLeveland then apply the verbosity flags to set the log level toDebug.Fixes: #122