clar: simplify how we handle stat(3P) on Win32 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows platform has multiple different definitions for stat(3P) and its `struct stat` with different integer widths for both the filesize and the timestamps. For our usecase, we really only need to care whether we end up using `_stat()` or `stat()`, which require us to use either `struct _stat` or `struct stat`, respectively. The way we handle this in "clar.c" is somewhat convoluted though because we select the function and structure to use independently of each other. This can cause us to pick the wrong combination of features in some environments, like mingw-w64. Refactor the code so that both function and struct get set up under the same condition, thus fixing the issue.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows platform has multiple different definitions for stat(3P) and its
struct statwith different integer widths for both the filesize and the timestamps. For our usecase, we really only need to care whether we end up using_stat()orstat(), which require us to use eitherstruct _statorstruct stat, respectively.The way we handle this in "clar.c" is somewhat convoluted though because we select the function and structure to use independently of each other. This can cause us to pick the wrong combination of features in some environments, like mingw-w64.
Simplify the code such both function and struct get set up under the same condition such that this cannot happen anymore.