clar: support compilation without support for wchar_t
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some implementations of libc do not have proper support for `wchar_t`. One such library is uClibc, which only has optional support for this type. When not enabled, then the <wchar.h> header will be a mere stub that only contains a typedef for `wchar_t`, but nothing else. Drop our use of `wchar_t` on such platforms. Reported-by: Bagas Sanjaya <[email protected]> Helped-by: Edgar Bonet <[email protected]>
pks-t
force-pushed
the
pks-uclibc-without-wchar
branch
from
c541adc
to
7fc9938
Compare
ethomson
approved these changes
Oct 21, 2024
edgar-bonet
reviewed
Oct 21, 2024
Comment on lines
+28
to
+32
| /* | ||
| * uClibc can optionally be built without wchar support, in which case | ||
| * the installed <wchar.h> is a stub that only defines the `whar_t` | ||
| * type but none of the functions typically declared by it. | ||
| */ |
There was a problem hiding this comment.
Actually, this wchar.h stub does not define wchar_t. It only defines wint_t and WEOF.
There was a problem hiding this comment.
Oops, right, thanks for the clarification!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some implementations of libc do not have proper support for
wchar_t. One such library is uClibc, which only has optional support for this type. When not enabled, then the <wchar.h> header will be a mere stub that only contains a typedef forwchar_t, but nothing else.Drop our use of
wchar_ton such platforms.