Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issues reported by Codacy #186

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

// import java.io.File;
// import java.io.FileNotFoundException;
// import java.io.FileOutputStream;
// import java.io.PrintWriter;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cassiosantos, if you commented these imports out does than mean they are not used?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those modules are used by a part of extractNEs function which is commented out. It's probably some debugging stuff. We can remove these lines as well as PrintWriter code from extractNEs function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines removed

@jhauswald jhauswald self-assigned this Jun 9, 2017
@jhauswald
Copy link
Contributor

Generally I like this although we are planning on restructuring the repo and move services out. @cassiosantos do you have experience with continuous integration and specifically if generally people loop it in as part of that pipeline? curious to know your thoughts!

@cassiosantos
Copy link
Contributor Author

@jhauswald restructuring the repository is a good idea.

Continuous integration comes with a set of good practices. I think it isn't necessary to use CI to take the advantage of automation.

I think that automated tests and builds could help people to contribute to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants