-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small issues reported by Codacy #186
base: master
Are you sure you want to change the base?
Conversation
68d6517
to
a405bf4
Compare
// import java.io.File; | ||
// import java.io.FileNotFoundException; | ||
// import java.io.FileOutputStream; | ||
// import java.io.PrintWriter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cassiosantos, if you commented these imports out does than mean they are not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those modules are used by a part of extractNEs
function which is commented out. It's probably some debugging stuff. We can remove these lines as well as PrintWriter code from extractNEs
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines removed
a405bf4
to
b3fca32
Compare
Generally I like this although we are planning on restructuring the repo and move services out. @cassiosantos do you have experience with continuous integration and specifically if generally people loop it in as part of that pipeline? curious to know your thoughts! |
@jhauswald restructuring the repository is a good idea. Continuous integration comes with a set of good practices. I think it isn't necessary to use CI to take the advantage of automation. I think that automated tests and builds could help people to contribute to the project. |
b3fca32
to
cc9566d
Compare
return
statementsequalsIgnoreCase()
is cleaner than usingtoUpperCase
/toLowerCase().equals()