Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework of tax to be included in gas #383

Closed
wants to merge 30 commits into from
Closed

Rework of tax to be included in gas #383

wants to merge 30 commits into from

Conversation

StrathCole
Copy link
Collaborator

@StrathCole StrathCole commented Nov 20, 2023 •
edited
Loading

Summary of changes

  • gas prices are added as on-chain governance parameters
  • tax is converted to gas by using gas price
  • ante handler only takes few gas, so on failed txs no tax is paid
  • overpaid tax is not deducted (depending on amount of fees sent)
  • tax for any denom can be paid in LUNC

Implementation draft for proposal #11873

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@StrathCole
- initial commit of classic tax module
6df1ba0 
- moved fee decorator
- restored stability tax to not handle uluna
- calculate gas from tax
@StrathCole
- upgrade handlers
b5330f8
@StrathCole
-
bbd2516
@StrathCole
- added genesis proto
f578b49
@StrathCole
- changed proto
7ef20c9
@StrathCole
- fixed types and init genesis order
51c78ed
@StrathCole
different adjustments and added debug logging
540903c
@StrathCole
- several fixes
f7c478c 
- correctly register oracle keeper in keeper
@StrathCole
- handle deducting fees
f45cf38 
- move to separate file
@StrathCole
- several fixes
c19bb12 
- deduct minimum gas fees in ante
- deduct rest of fees in post with tax
@StrathCole
- fix
2fe80e6 
- added comments to functions and code blocks
@StrathCole
- handle tax in wasm and deduct tax from coins sent instead of contra…
bbee581 
…ct balance
@StrathCole
- smaller fixes
4776ba5
@StrathCole
- fixed old tax tests
4b323b2 
- added unit tests
@StrathCole
- fixed further tests
a78df27 
- removed debug output
@StrathCole
- add further test and move suite
1af9865
@StrathCole
- remove fees on height 0 (genesis transactions)
bfffded
@StrathCole
Merge remote-tracking branch 'upstream/main' into classictax
d41cc6d
@StrathCole
- added missing grpc registering
b75f526 
- code improvements
@StrathCole
- added swagger for classictax module
edf5723
@StrathCole
Merge remote-tracking branch 'upstream/main' into classictax
729a011
@StrathCole
- change exchange rate calculation to gas prices
3cdf8bb 
(oracle cannot be used unless USTC is added as a further crypto-currency-rate)
@StrathCole
- add burned event to emitted events
d18338b
@StrathCole
Copy link
Collaborator Author

This is superseded by GLabs tax2gas implementation

@StrathCole StrathCole closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghuyenthevinh2000 nghuyenthevinh2000 Awaiting requested review from nghuyenthevinh2000

@fragwuerdig fragwuerdig Awaiting requested review from fragwuerdig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StrathCole