feat (helm): make cfssl image configurable in helm values #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kamaji-documentation canceled.
|
prometherion
requested changes
Feb 22, 2024
killianmuldoon
force-pushed
the
pr-make-cfssl-image-configurable
branch
3 times, most recently
from
fb7524f to
224d053
Compare
killianmuldoon
changed the title
killianmuldoon
commented
Feb 22, 2024
charts/kamaji/Chart.yaml
Outdated
| @@ -15,7 +15,7 @@ name: kamaji | |||
| sources: | |||
| - https://github.com/clastix/kamaji | |||
| type: application | |||
| version: 0.14.0 | |||
| version: 0.14.2 | |||
There was a problem hiding this comment.
I think this is the right version as the latest I previously pulled was 0.14.1. Not sure if this is the only place to set the version.
There was a problem hiding this comment.
Our convention is minor bumping when adding a feature: if you don't mind, let's go for the 0.15.0.
killianmuldoon
force-pushed
the
pr-make-cfssl-image-configurable
branch
3 times, most recently
from
f401d61 to
e25c4fe
Compare
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-make-cfssl-image-configurable
branch
from
e25c4fe to
6244548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuration of the cfssl image in the helm values. There's a bug in the current arm64 builds for the cfssl image -cloudflare/cfssl#1359 - meaning I can't run Kamaji currently on arm64.
Making this image configurable allows users to build their own to get around this issue.